cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Redirect when event type does not match booking type

Open emrysal opened this issue 1 year ago • 7 comments

What does this PR do?

Bit of a complex one TS wise, should speed up TS performance however.

  • Redirects to the "owning" event type when the booking reschedule UID belongs to another event type.
  • Also fixes handling of rescheduleUid if supplied to the URL like rescheduleUid[]="trying"&rescheduleUid[]="to-break-the-system"

emrysal avatar Apr 08 '24 15:04 emrysal

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Apr 08 '24 15:04 github-actions[bot]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Apr 08 '24 16:04 graphite-app[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:13pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 1:13pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 1:13pm
qa ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 1:13pm

vercel[bot] avatar Apr 08 '24 16:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 08 '24 16:04 github-actions[bot]

Current Playwright Test Results Summary

✅ 320 Passing - ⚠️ 10 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/08/2024 01:28:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ce4a163b15bf5d00c379cc324da04a1791892f8e

Started: 05/08/2024 01:24:58pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 1Initial Attempt
0.59% (2) 2 / 338 runs
failed over last 7 days
11.24% (38) 38 / 338 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
24.38% (88) 88 / 361 runs
failed over last 7 days
31.86% (115) 115 / 361 runs
flaked over last 7 days
Update Profile Newly added secondary email should show as Unverified
Retry 1Initial Attempt
0.83% (3) 3 / 362 runs
failed over last 7 days
15.19% (55) 55 / 362 runs
flaked over last 7 days

📄   apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1Initial Attempt
0% (0) 0 / 322 runs
failed over last 7 days
23.29% (75) 75 / 322 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1Initial Attempt
0% (0) 0 / 329 runs
failed over last 7 days
52.89% (174) 174 / 329 runs
flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1Initial Attempt
0.61% (2) 2 / 329 runs
failed over last 7 days
51.67% (170) 170 / 329 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1Initial Attempt
0.91% (3) 3 / 329 runs
failed over last 7 days
51.98% (171) 171 / 329 runs
flaked over last 7 days
Namespacing Different namespaces can have different init configs
Retry 1Initial Attempt
0% (0) 0 / 329 runs
failed over last 7 days
52.28% (172) 172 / 329 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0.31% (1) 1 / 326 run
failed over last 7 days
36.81% (120) 120 / 326 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Email verification sent if enabled
Retry 1Initial Attempt
0.88% (3) 3 / 341 runs
failed over last 7 days
9.68% (33) 33 / 341 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Apr 08 '24 16:04 deploysentinel[bot]

@emrysal can you solve merge conflicts 🙏

CarinaWolli avatar Apr 18 '24 14:04 CarinaWolli

@emrysal can you fix the merge conflicts?

Udit-takkar avatar May 06 '24 06:05 Udit-takkar