fix: Credential syncing - ensure response data is always returned.

[joeauyeung]

What does this PR do?

Currently, our apps handle the response of their refresh token requests in different ways, either with the response directly or the response body. This PR aims to have the token refresh requests to always return the response body.

Fixes # (issue)

Requirement/Documentation

• If there is a requirement document, please, share it here.
• If there is a UI/UX design document, please, share it here.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• For each app changed in this PR, ensure that the tokens are being refreshed properly

Mandatory Tasks

• [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

[github-actions[bot]]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[graphite-app[bot]]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 301 Passing - ❌ 2 Failing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/02/2024 02:21:11am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 574557424a0e0f61abc152b59da094a50674f069

Started: 04/02/2024 02:17:46am UTC

❌ Failures

📄   apps/web/playwright/out-of-office.e2e.ts • 2 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Out of office User can create out of office entry Retry 2 • Retry 1 • Initial Attempt Error: Timed out 30000ms waiting for expect(received).toBeVisible()... Timed out 30000ms waiting for expect(received).toBeVisible() Call log: - expect.toBeVisible with timeout 30000ms - waiting for locator('data-testid=table-redirect-n-a') - waiting for locator('data-testid=table-redirect-n-a')	13.25% (22) 22 / 166 runs failed over last 7 days	0% (0) 0 / 166 runs flaked over last 7 days
Out of office User can configure booking redirect Retry 2 • Retry 1 • Initial Attempt Error: Timed out 30000ms waiting for expect(received).toBeVisible()... Timed out 30000ms waiting for expect(received).toBeVisible() Call log: - expect.toBeVisible with timeout 30000ms - waiting for locator('data-testid=table-redirect-user-9-1712024419602') - waiting for locator('data-testid=table-redirect-user-9-1712024419602')	13.25% (22) 22 / 166 runs failed over last 7 days	0% (0) 0 / 166 runs flaked over last 7 days

---

⚠️ Flakes

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard Retry 2 • Retry 1 • Initial Attempt	0.62% (1) 1 / 162 run failed over last 7 days	28.40% (46) 46 / 162 runs flaked over last 7 days

---

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved Retry 1 • Initial Attempt	0.64% (1) 1 / 157 run failed over last 7 days	17.20% (27) 27 / 157 runs flaked over last 7 days

---

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
pro user -- legacy Time slots should be reserved when selected Retry 1 • Initial Attempt	0% (0) 0 / 164 runs failed over last 7 days	7.93% (13) 13 / 164 runs flaked over last 7 days

---

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to an organization Retry 1 • Initial Attempt	0% (0) 0 / 172 runs failed over last 7 days	8.72% (15) 15 / 172 runs flaked over last 7 days
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization Retry 1 • Initial Attempt	1.74% (3) 3 / 172 runs failed over last 7 days	14.53% (25) 25 / 172 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Preview Preview - embed-core should load Retry 1 • Initial Attempt	0% (0) 0 / 168 runs failed over last 7 days	29.17% (49) 49 / 168 runs flaked over last 7 days

---

📄   apps/web/playwright/wipe-my-cal.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Wipe my Cal App Test Browse upcoming bookings and validate button shows and triggering wipe my cal button Retry 1 • Initial Attempt	0% (0) 0 / 170 runs failed over last 7 days	0.59% (1) 1 / 170 run flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme Retry 1 • Initial Attempt	1.19% (2) 2 / 168 runs failed over last 7 days	50.60% (85) 85 / 168 runs flaked over last 7 days

---

View Detailed Build Results

---

[keithwillcode]

@joeauyeung is this PR still valid now that #14588 went in?

[joeauyeung]

Close in favour of https://github.com/calcom/cal.com/pull/14588