cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Assign recurring round-robin events to different hosts

Open Amit91848 opened this issue 1 year ago • 9 comments

What does this PR do?

Fixes #13937 Fixes CAL-3250

Assign to different hosts is false

https://github.com/calcom/cal.com/assets/74371312/ff8c9d6e-753d-4ebd-9079-06af8319f8f4

Assign to different hosts is true

https://github.com/calcom/cal.com/assets/74371312/ae4471a2-b2d3-441d-8a0d-3aded34f6a94

Type of change

  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Amit91848 avatar Mar 20 '24 08:03 Amit91848

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 20 '24 08:03 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Mar 20 '24 08:03 github-actions[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (03/31/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Mar 20 '24 08:03 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Mar 20 '24 08:03 github-actions[bot]

Thank you for working on that new feature 🙏 There are some more things we need to take into account when assigning recurring events to different hosts. A few things I can think of:

  • Every assigned host needs to get an email notification with the dates they were booked for
  • We need to have the bookings show up in each host's calendars (only the ones they were assigned to)
  • Booking success page shows just one out of all the hosts. We maybe rather want to show something like 'members of Team Name' and maybe below show the host of the host assigned to the first booking

Okay, will start working on these.

Amit91848 avatar Mar 21 '24 15:03 Amit91848

  • Every assigned host needs to get an email notification with the dates they were booked for We need to have the bookings show up in each host's calendars (only the ones they were assigned to)

From host pov, are we going to treat it as a normal event or recurring event? Like for titles and text in email and calendar, should it say recurring event?

Amit91848 avatar Mar 21 '24 15:03 Amit91848

@CarinaWolli made some changes. Now host get a separate email for each individual booking. We can maybe send email at last when all bookings are done, and send only a single email per host with all its times in it. Lmk what you think about this. Also changed the booking page.

https://github.com/calcom/cal.com/assets/74371312/766ecb0b-3326-4802-9e94-db7805ef0f2c

Amit91848 avatar Mar 31 '24 15:03 Amit91848

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 09 '24 00:05 github-actions[bot]

Now host get a separate email for each individual booking. We can maybe send email at last when all bookings are done, and send only a single email per host with all its times in it. Lmk what you think about this. Also changed the booking page.

Yes, we should definitely only send one email per host. That email should list all the dates the host is booked for

CarinaWolli avatar May 10 '24 13:05 CarinaWolli

@Amit91848 any update on this? you can request re review if it's ready.

Udit-takkar avatar May 24 '24 11:05 Udit-takkar

@Amit91848 any update on this? you can request re review if it's ready.

Some work is still left. Will try to finish it over the weekend

Amit91848 avatar May 24 '24 13:05 Amit91848

@CarinaWolli for attendee the event title uses first host name for both booking page and email, should we change that too?

Also cancel and reschedule links for host goes to first event of the respective host, should this be changed?

  • It would be best if the video link would be the same for all recurring events. Right now it shows one video link in the attendee email but the video links are different between hosts

For same hosts, all bookings have different video links, only host and attendee email show same first video link. Do you want all bookings to have the same link, or only the email to have same link?

Amit91848 avatar May 30 '24 09:05 Amit91848

@CarinaWolli for attendee the event title uses first host name for both booking page and email, should we change that too?

Yes, should also only show the team name not the first host 🙏

Also cancel and reschedule links for host goes to first event of the respective host, should this be changed?

I saw that, I think that's fine 👍

For same hosts, all bookings have different video links, only host and attendee email show same first video link. Do you want all bookings to have the same link, or only the email to have same link?

I think having one video link is the best and least confusing solution. So no matter what host, the video link in the emails and calendar events is always the same

CarinaWolli avatar May 30 '24 13:05 CarinaWolli

@CarinaWolli I added a simple unit test and fixed email.

I think having one video link is the best and least confusing solution. So no matter what host, the video link in the emails and calendar events is always the same

Can you look into this, I couldn't figure this out.

Amit91848 avatar May 30 '24 16:05 Amit91848

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jun 14 '24 00:06 github-actions[bot]

Closing due to staleness. Please reopen if work continues.

keithwillcode avatar Sep 04 '24 10:09 keithwillcode