cal.com
cal.com copied to clipboard
calcom
fix: zoho installaltion
What does this PR do?
This PR fixes error that we get on zohocalender installation.
Fixes # (issue) fixes #12955 fixes #12405
Before https://www.loom.com/share/b82a551a2a2c4b11ad6aefdcc55104e9?sid=d2a638a4-ad7f-4670-8a77-0edab4f7c3ff After https://www.loom.com/share/06ad87f1c8ee4e30a44753daea034f67?sid=478e9091-9028-418e-8783-4592e94fc3d2
Type of change
- Bug fix (non-breaking change which fixes an issue)
How should this be tested?
Changes of this PR can be verified by installing zohocalender for different region's accounts like US, IN, EU etc
@Pritam-sd-dev is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Graphite Automations
A Graphite automation took an action on this PR • (02/28/24)
1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'
A Graphite automation took an action on this PR • (02/17/24)
1 label was added based on Keith Williams's automation, 'Add community label'
![graphite-app[bot] avatar](https://avatars.githubusercontent.com/in/158384?v=4 "Published by a pub.dev verified publisher"){kind=small}
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
Thanks for your contribution @Pritam-sd-dev. I'm reviewing your PR and I'm trying to understand how this PR would solve those issues.
From what I see the serverDomain is something we would set on our side. If the server is in the US and stays as .com how would that address the issue?
@joeauyeung You can refer to https://www.zoho.com/crm/developer/docs/api/v6/multi-dc.html When we make Auth request in response we get a value of server.
But what if user wants to have multiple calendars with different domain ?
But what if user wants to have multiple calendars with different domain ?
That's a good point. If a user has a calendar with a different domain is that also a different Zoho account? Every time a Cal.com user goes through the Zoho OAuth flow we create a different credential so we can still store the domain data under the key field of each credential.