fix: rescheduling daily

[Udit-takkar]

What does this PR do?

Fixes https://github.com/calcom/cal.com/issues/13563

Rescheduling works fine for daily video but doesn't work when your location is empty string. It could be possible when there is no location selected on event type settings.

updateMeeting(in dailyvideo/lib/VideoApiAdapter) was never called because location is empty string.

How to reproduce the bug?

1. Remove all location from event type settings
2. Book a meeting
3. Reschedule the meeting

Then check the location url is daily video url and check sidebar if it is updated to new date and time

Type of change

• Bug fix (non-breaking change which fixes an issue)

[github-actions[bot]]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 302 Passing - ⚠️ 11 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/13/2024 01:21:16pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f22d6e3a035860b6ddebc72fb7d3e025dcaf906a

Started: 04/13/2024 01:17:27pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user Different Locations Tests can add single organizer address location without display location public option Retry 2 • Retry 1 • Initial Attempt	0.37% (1) 1 / 270 run failed over last 7 days	3.33% (9) 9 / 270 runs flaked over last 7 days

---

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard Retry 2 • Retry 1 • Initial Attempt	4.56% (12) 12 / 263 runs failed over last 7 days	31.94% (84) 84 / 263 runs flaked over last 7 days

---

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Availablity Can manage single schedule Retry 1 • Initial Attempt	0.36% (1) 1 / 280 run failed over last 7 days	25.36% (71) 71 / 280 runs flaked over last 7 days

---

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work Retry 1 • Initial Attempt	0% (0) 0 / 270 runs failed over last 7 days	11.85% (32) 32 / 270 runs flaked over last 7 days
Routing Forms Seeded Routing Form Test preview should return correct route Retry 2 • Retry 1 • Initial Attempt	0.37% (1) 1 / 269 run failed over last 7 days	34.57% (93) 93 / 269 runs flaked over last 7 days

---

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can update a users email (verification enabled) Retry 1 • Initial Attempt	6.69% (18) 18 / 269 runs failed over last 7 days	24.91% (67) 67 / 269 runs flaked over last 7 days
Update Profile Can verify the newly added secondary email Retry 1 • Initial Attempt	0% (0) 0 / 267 runs failed over last 7 days	6.37% (17) 17 / 267 runs flaked over last 7 days

---

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members Retry 1 • Initial Attempt	9.22% (26) 26 / 282 runs failed over last 7 days	35.11% (99) 99 / 282 runs flaked over last 7 days

---

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done existing user migrated to an organization Retry 1 • Initial Attempt	0% (0) 0 / 269 runs failed over last 7 days	4.46% (12) 12 / 269 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Preview Preview - embed-core should load Retry 1 • Initial Attempt	0% (0) 0 / 270 runs failed over last 7 days	41.85% (113) 113 / 270 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme Retry 1 • Initial Attempt	0.74% (2) 2 / 270 runs failed over last 7 days	54.07% (146) 146 / 270 runs flaked over last 7 days

---

View Detailed Build Results

---

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview		Apr 13, 2024 1:05pm
cal	⬜️ Ignored (Inspect)	Visit Preview		Apr 13, 2024 1:05pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Apr 13, 2024 1:05pm
qa	⬜️ Ignored (Inspect)	Visit Preview		Apr 13, 2024 1:05pm
qa-not-in-use	⬜️ Ignored (Inspect)	Visit Preview		Apr 13, 2024 1:05pm

[Udit-takkar]

Idk tests are working fine locally

[keithwillcode]

@Udit-takkar Why weren't tests added to confirm this change?

[Udit-takkar]

@Udit-takkar Why weren't tests added to confirm this change?

I already added one test for this https://github.com/calcom/cal.com/pull/13103 some time ago (when location is daily video). only difference is when location is empty string update it to "integrations:daily" which is verified by webhook test

[keithwillcode]

@Udit-takkar Why weren't tests added to confirm this change?

I already added one test for this #13103 some time ago (when location is daily video). only difference is when location is empty string update it to "integrations:daily" which is verified by webhook test

Ok. Ideally moving forward we write more direct tests ensuring logic is correct. The webhook test is good but a bit indirect verification of the logic versus direct verification of the logic.

[CarinaWolli]

@Udit-takkar any idea why tests are failing here?

[Udit-takkar]

@Udit-takkar any idea why tests are failing here?

I have fixed one but don't know why this test is failing. It is passing successfully locally.

[CarinaWolli]

I have fixed one but don't know why this test is failing. It is passing successfully locally.

DAILY_API_KEY isn't set and that's why createMeeting fails and emails aren't sent. @keithwillcode can we set DAILY_API_KEY for e2e tests?

[keithwillcode]

DAILY_API_KEY isn't set and that's why createMeeting fails and emails aren't sent. @keithwillcode can we set DAILY_API_KEY for e2e tests?

It's already set up as CI_DAILY_API_KEY. Just need to map it correctly in the workflow actions files. https://github.com/calcom/cal.com/blob/7422488b5dab650259efde45e0b64763dd432757/.github/workflows/e2e.yml#L47 https://github.com/calcom/cal.com/blob/7422488b5dab650259efde45e0b64763dd432757/.github/workflows/e2e-embed.yml#L49 https://github.com/calcom/cal.com/blob/7422488b5dab650259efde45e0b64763dd432757/.github/workflows/e2e-app-store.yml#L56 https://github.com/calcom/cal.com/blob/7422488b5dab650259efde45e0b64763dd432757/.github/workflows/e2e-embed-react.yml#L43

[github-actions[bot]]

This PR is being marked as stale due to inactivity.

[linear[bot]]

CAL-3389 Rescheduling bug

[CarinaWolli]

1. Remove all location from event type settings
2. Book a meeting
3. Reschedule the meeting Then check the location url is daily video url and check sidebar if it is updated to new date and time

I tried that in production and the daily link did show the updated date and time. How do I reproduce this bug?