cal.com
cal.com copied to clipboard
calcom
feat: show top banner for broken integrations [Cal 3125]
What does this PR do?
check for invalid credentials and display the banner
video : https://www.loom.com/share/aa0ed6ad42ea422485ce068ae39e0c9f?sid=9dd3a6f4-79f7-4ed5-b143-2de52ad0ab21
Fixes #13667 /claim #13667
Type of change
-
New feature (non-breaking change which adds functionality)
-
My code follow the style guidelines of this project
-
I checked if new and existing unit tests pass locally with my changes
@Hitesh-Sisara is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Graphite Automations
A Graphite automation took an action on this PR • (02/16/24)
1 reviewer was added based on Keith Williams's automation, 'Add foundation team as reviewer'
A Graphite automation took an action on this PR • (02/29/24)
1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'
A Graphite automation took an action on this PR • (02/16/24)
1 label was added based on Keith Williams's automation, 'Add community label'
![graphite-app[bot] avatar](https://avatars.githubusercontent.com/in/158384?v=4 "Published by a pub.dev verified publisher"){kind=small}
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
Hey @Udit-takkar, In the file packages/features/shell/Shell.tsx on line 271 why are we using if else ladder when we do the same thing in each case? If we change it from using if else to normal return then it will make the code smaller as well as reduce 1 step for the next contributor
Hey @Udit-takkar, In the file packages/features/shell/Shell.tsx on line 271 why are we using if else ladder when we do the same thing in each case? If we change it from using if else to normal return then it will make the code smaller as well as reduce 1 step for the next contributor
I was getting type error when i didn't use if else statements