cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: date-ranges logic and date-ranges tests

Open MehulZR opened this issue 1 year ago • 8 comments

What does this PR do?

Fixes:

  • Tests which fails when run in a different timezone
  • Tests we were skipping & Enabling them.
  • incorrect working hours when dst change happen between start of availability and end of availability

Test: Added test for correct working hours when dst change happen between start of availability and end of availability

https://github.com/calcom/cal.com/pull/13526#issuecomment-1938638415

Explaination

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] Tests (Unit/Integration/E2E or any other test)

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

MehulZR avatar Feb 15 '24 12:02 MehulZR

@MehulZR is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 15 '24 12:02 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Feb 15 '24 12:02 github-actions[bot]

Graphite Automations

"Add community label" took an action on this PR • (02/15/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (03/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Feb 15 '24 12:02 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/settings/organizations/members 438.57 KB 626.96 KB 179.13% (🟡 +1.31%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Feb 15 '24 12:02 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Mar 02 '24 00:03 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Apr 11 '24 00:04 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Apr 30 '24 00:04 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 31 '24 00:05 github-actions[bot]

Hey @MehulZR just FYI I'm actively reviewing this (hense you're seeing commits here and there)

emrysal avatar Jul 17 '24 13:07 emrysal

Hey @MehulZR just FYI I'm actively reviewing this (hense you're seeing commits here and there)

Are you talking about endResult was still defined as 'const' & Merge branch 'main' into fix_date-ranges ?

MehulZR avatar Jul 17 '24 14:07 MehulZR