cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-3098] before/after buffer not working correctly for events with seats

Open CarinaWolli opened this issue 1 year ago • 4 comments

Issue Summary

Before and after event buffers don't work correctly on events with seats.

Steps to Reproduce

  1. Create an event type with seats and 60 mins before + 60 mins after buffer
  2. Book first seat of a slot
  3. After the first seat is booked the buffers should already be applied, but slots are still open before and after 60 minutes of the event

It's only not working for the event type itself. For all other event types (with or without seats) the buffer for this seated booking we just made is correctly applied and these slots are not shown as available.

CAL-3098

CarinaWolli avatar Feb 08 '24 18:02 CarinaWolli

hey @keithwillcode I have just found what is issue here but I don't know what exact solution will work here if the event is booked by one user that means he should not able to see slot open for any event type and all other users will able to book the event type if that's the case I have solved issue

Rahul190299 avatar Feb 14 '24 19:02 Rahul190299

Let's say the seated event has a before buffer of 2 hours. If the first seat gets booked, then the buffer should be applied. Meaning: the slots 2 hours before the booking are not available, the slot from the booking itself is still open for the rest of the seats, and the slots 2 hours after are blocked too (as the next slot also need the 2 hours before buffer)

@Rahul190299 does this make sense?

CarinaWolli avatar Feb 14 '24 19:02 CarinaWolli

i have checked in code the booked slot is not get added to busy slot array due to and condition applied on event type hence its not working for event type itself for rest all event type in my fix i have added check for user who booked slot instead on event type and its working fine but i doubt it will not break other things

Rahul190299 avatar Feb 15 '24 17:02 Rahul190299

Moving to 4.0 because of other priorities

keithwillcode avatar Mar 05 '24 14:03 keithwillcode