cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-3116] `bookingSuccessful` event is emitted even when the user clicks on `Cancel`, `Nevermind` etc...

Open baptisteArno opened this issue 1 year ago β€’ 1 comments

Issue Summary

When embedding a cal.com widget, the bookingSuccessful event is emitted even when the user clicks on Cancel, Nevermind etc...

I'd expect it to only be emitted whenever an event is successfully booked.

Steps to Reproduce

  1. Embed a widget
  2. Subscribe a callback to bookingSuccessful event
  3. Book an event, then click on Cancel, then Nevermind

CAL-3116

baptisteArno avatar Feb 06 '24 15:02 baptisteArno

This issue has been labeled as a bug related to the embed feature. The team will review it and take the necessary actions. Thank you for reporting this!

From Maige. How's my driving?

maige-app[bot] avatar Feb 06 '24 15:02 maige-app[bot]

Hi! I would like to take this up if it is available

Yash-271120 avatar Apr 18 '24 21:04 Yash-271120

@baptisteArno This is fixed in this PR https://github.com/calcom/cal.com/pull/13755. Mind testing this again

cc @PeerRich

asadath1395 avatar Jun 19 '24 13:06 asadath1395