cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: let org admins change usernames

Open PeerRich opened this issue 7 months ago • 8 comments

TODO

  • [x] Fix Avatar update bugs

havent tested but could work, unless the API needs more permission to change username, not sure

CleanShot 2024-01-24 at 12 59 34@2x

PeerRich avatar Jan 24 '24 13:01 PeerRich

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 7:37am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 7:37am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 7:37am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 7:37am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 7:37am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 7:37am
qa ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 7:37am
ui ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 7:37am

vercel[bot] avatar Jan 24 '24 13:01 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 24 '24 13:01 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jan 24 '24 13:01 github-actions[bot]

Current Playwright Test Results Summary

✅ 447 Passing - ⚠️ 17 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/22/2024 07:47:05am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: cecbfe6b23292b490b58b7a05d8fdeb9ff86049e

Started: 02/22/2024 07:38:15am UTC

⚠️ Flakes

📄   apps/web/playwright/change-username.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change username on settings User can change username
Retry 1Initial Attempt
1.46% (3) 3 / 206 runs
failed over last 7 days
3.40% (7) 7 / 206 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Checkbox Group Question Long Text and Checkbox Group required
Retry 1Initial Attempt
0% (0) 0 / 210 runs
failed over last 7 days
2.86% (6) 6 / 210 runs
flaked over last 7 days
Booking With Long Text Question and Each Other Question Long Text required and Number not required
Retry 1Initial Attempt
0.48% (1) 1 / 210 run
failed over last 7 days
5.24% (11) 11 / 210 runs
flaked over last 7 days
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Phone Question Long Text required and Phone not required
Retry 1Initial Attempt
0% (0) 0 / 209 runs
failed over last 7 days
5.26% (11) 11 / 209 runs
flaked over last 7 days
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text and select required
Retry 1Initial Attempt
0% (0) 0 / 208 runs
failed over last 7 days
6.73% (14) 14 / 208 runs
flaked over last 7 days

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and Radio group Question Select required and Radio group required
Retry 1Initial Attempt
0% (0) 0 / 222 runs
failed over last 7 days
4.50% (10) 10 / 222 runs
flaked over last 7 days

📄   apps/web/playwright/booking/responsiveBooking.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking page with no questions Booking page with 1920x1080 resolution
Retry 1Initial Attempt
0% (0) 0 / 225 runs
failed over last 7 days
8% (18) 18 / 225 runs
flaked over last 7 days
Booking page with no questions Booking page with 1280x720 resolution
Retry 1Initial Attempt
0% (0) 0 / 225 runs
failed over last 7 days
8.44% (19) 19 / 225 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
0.47% (1) 1 / 215 run
failed over last 7 days
43.26% (93) 93 / 215 runs
flaked over last 7 days
Login and logout tests -- future Login flow validations -- legacy Should warn when user does not exist
Retry 1Initial Attempt
0% (0) 0 / 215 runs
failed over last 7 days
1.40% (3) 3 / 215 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and multiselect Question Radio and multiselect text not required
Retry 1Initial Attempt
0% (0) 0 / 227 runs
failed over last 7 days
5.73% (13) 13 / 227 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and select Question Phone required and select not required
Retry 1Initial Attempt
0% (0) 0 / 229 runs
failed over last 7 days
4.80% (11) 11 / 229 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Address and Long Text not required
Retry 1Initial Attempt
0% (0) 0 / 220 runs
failed over last 7 days
6.82% (15) 15 / 220 runs
flaked over last 7 days
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address and Multi email not required
Retry 1Initial Attempt
0% (0) 0 / 220 runs
failed over last 7 days
5.45% (12) 12 / 220 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 2Retry 1Initial Attempt
1.36% (3) 3 / 220 runs
failed over last 7 days
20.45% (45) 45 / 220 runs
flaked over last 7 days

📄   apps/web/playwright/reschedule.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests Unpaid rescheduling should go to payment page
Retry 1Initial Attempt
0.87% (2) 2 / 230 runs
failed over last 7 days
0.87% (2) 2 / 230 runs
flaked over last 7 days
Reschedule Tests Paid rescheduling should go to success page
Retry 1Initial Attempt
0.87% (2) 2 / 230 runs
failed over last 7 days
0.43% (1) 1 / 230 run
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Jan 24 '24 13:01 deploysentinel[bot]

Type checks are failing

likely more failing, havent tested locally at all yet 🙏

PeerRich avatar Jan 24 '24 14:01 PeerRich

Type checks are failing

should fix the type checks now

Ryukemeister avatar Jan 25 '24 05:01 Ryukemeister

Fixed:- Username Updation

https://github.com/calcom/cal.com/assets/53316345/7c11fe71-81dc-4309-a457-8b968ecc88c4

Udit-takkar avatar Feb 17 '24 07:02 Udit-takkar

I tried updating this test user "test-example" to "pro" but got a unique constraint error

No users in this org have this name either

Okay let me try to replicate this bug.

Udit-takkar avatar Feb 19 '24 08:02 Udit-takkar

@sean-brydon Works fine for me. There is user with 'pro' username in the DB but not in the org

https://github.com/calcom/cal.com/assets/53316345/bda95149-37b2-46ed-8b9d-77562d258b72

Udit-takkar avatar Feb 19 '24 10:02 Udit-takkar