cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-2978] Adapt Dialog to use Drawers on modals

Open sean-brydon opened this issue 1 year ago • 11 comments

@shadcn UI has a great example of this. We should do something simular and ensure we match our design system.

Discussed with @Jaibles in DMs and we think this is a good approach as our modals can get a bit messy on mobile with some nasty scrolling.

From SyncLinear.com | CAL-2978

sean-brydon avatar Jan 20 '24 06:01 sean-brydon

please assign this to me

aakash2330 avatar Jan 20 '24 16:01 aakash2330

@sean-brydon can you explain more a bit or can post a screen cap/video of this?

pratikprajapati0708 avatar Jan 21 '24 18:01 pratikprajapati0708

@sean-brydon can you explain more a bit or can post a screen cap/video of this?

Hi - what i mean is our "Dialog" component should be swapped out for the Responsive Dialog + Modal like in the example of "ShadCn"

The designs for modal should match those in our figma file

sean-brydon avatar Jan 25 '24 09:01 sean-brydon

can outside contributors access the figma file ?

aakash2330 avatar Jan 25 '24 12:01 aakash2330

May i work on it, please, assign me the issue. @sean-brydon

SwapnilSonker avatar Feb 03 '24 09:02 SwapnilSonker

May i work on it, please, assign me the issue. @sean-brydon

Hi - we don't assign issues but feel free to work on it and we will review your PR once its completed

sean-brydon avatar Feb 03 '24 09:02 sean-brydon

this issue is not explained very well... am i suppose to replace all the dialogue boxes in the application?? please explain the issue i would like to work on it. @sean-brydon

Bhushankadam17 avatar Feb 09 '24 16:02 Bhushankadam17

I found cal.com's figma design file but i am not able to locate the Dialog component, can you help me point out where it is, so that i can start working on this issue? @sean-brydon

dhruvkaravadiya avatar May 16 '24 12:05 dhruvkaravadiya