revert: 'fix: preview url for booking page'

[Udit-takkar]

What does this PR do?

Fixes reverts this PR https://github.com/calcom/cal.com/pull/12973

https://threads.com/thread/34561538856/34561538859?s=dUJjVzSUcZCeQtprQ7CdUc

Type of change

• Bug fix (non-breaking change which fixes an issue)

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 7, 2024 5:08pm
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 7, 2024 5:08pm
dev	❌ Failed (Inspect)			Feb 7, 2024 5:08pm

5 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Feb 7, 2024 5:08pm
cal-demo	⬜️ Ignored (Inspect)	Visit Preview		Feb 7, 2024 5:08pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Feb 7, 2024 5:08pm
qa	⬜️ Ignored (Inspect)	Visit Preview		Feb 7, 2024 5:08pm
ui	⬜️ Ignored (Inspect)	Visit Preview		Feb 7, 2024 5:08pm

[github-actions[bot]]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 442 Passing - ⚠️ 16 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/07/2024 05:21:20pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 593f23a33c7d1d9549a052ba06fcd55d62a5546c

Started: 02/07/2024 05:11:16pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Address Question Multiple Email and Address not required Retry 1 • Initial Attempt	2.14% (7) 7 / 327 runs failed over last 7 days	3.98% (13) 13 / 327 runs flaked over last 7 days
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and Short text question Multiple Email required and Short text required Retry 1 • Initial Attempt	0.32% (1) 1 / 315 run failed over last 7 days	4.76% (15) 15 / 315 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null	3 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and checkbox Question Long Text required and checkbox not required Retry 1 • Initial Attempt	0% (0) 0 / 311 runs failed over last 7 days	3.54% (11) 11 / 311 runs flaked over last 7 days
Booking With Long Text Question and Each Other Question Booking With Long Text Question and multiselect Question Long Text and multiselect text required Retry 1 • Initial Attempt	0.65% (2) 2 / 310 runs failed over last 7 days	5.81% (18) 18 / 310 runs flaked over last 7 days
Booking With Long Text Question and Each Other Question Long Text required and Number not required Retry 1 • Initial Attempt	0.32% (1) 1 / 310 run failed over last 7 days	5.81% (18) 18 / 310 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking page with no questions Booking page with 640x480 resolution Retry 1 • Initial Attempt	0% (0) 0 / 300 runs failed over last 7 days	4.67% (14) 14 / 300 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox group Question Select required and checkbox group required Retry 1 • Initial Attempt	0% (0) 0 / 299 runs failed over last 7 days	3.68% (11) 11 / 299 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Number Question Checkbox Group and Number not required Retry 2 • Retry 1 • Initial Attempt	0.95% (3) 3 / 317 runs failed over last 7 days	5.36% (17) 17 / 317 runs flaked over last 7 days

---

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard Retry 1 • Initial Attempt	5.11% (16) 16 / 313 runs failed over last 7 days	37.38% (117) 117 / 313 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and multiselect Question Address and multiselect text not required Retry 1 • Initial Attempt	0% (0) 0 / 329 runs failed over last 7 days	4.86% (16) 16 / 329 runs flaked over last 7 days

---

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Cannot update a users email when existing user has same email (verification enabled) Retry 1 • Initial Attempt	0% (0) 0 / 16 runs failed over last 7 days	56.25% (9) 9 / 16 runs flaked over last 7 days

---

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Team invitation Retry 1 • Initial Attempt	14.33% (47) 47 / 328 runs failed over last 7 days	12.80% (42) 42 / 328 runs flaked over last 7 days

---

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can add Cal video location and book with it Retry 1 • Initial Attempt	2.29% (8) 8 / 350 runs failed over last 7 days	3.71% (13) 13 / 350 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Preview Preview - embed-core should load Retry 1 • Initial Attempt	0% (0) 0 / 333 runs failed over last 7 days	30.03% (100) 100 / 333 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Phone and Address required Retry 1 • Initial Attempt	0.90% (3) 3 / 332 runs failed over last 7 days	4.22% (14) 14 / 332 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme Retry 1 • Initial Attempt	0.60% (2) 2 / 331 runs failed over last 7 days	41.09% (136) 136 / 331 runs flaked over last 7 days

---

View Detailed Build Results

---

[keithwillcode]

Converted back to draft while until decision is made

[Udit-takkar]

@keithwillcode we should wait for @zomars or @hariombalhara approval before merging

[hariombalhara]

I still don't think we should revert this.

Also, if we need to revert this, it should just be the changes you made in the PR https://github.com/calcom/cal.com/pull/12973. Right now it seem to be doing a complete replacement of CAL_URL.

Also, CAL_URL handles the case of our previews, where website isn't setup and then we use WEBAPP_URL only. We need to consider that in any new approach that we use.

Are there any more reports of broken links except the one case reported on threads?

I have an expectation that WEBSITE_URL is set same as WEBAPP_URL by default(as set in .env.example), unless someone changes it, so WEBSITE_URL is always set and CAL_URL is same as WEBSITE_URL with some special handling

[Udit-takkar]

I still don't think we should revert this.

Also, if we need to revert this, it should just be the changes you made in the PR #12973. Right now it seem to be doing a complete replacement of CAL_URL.

Reverting #12973 would display preview urls as 'app.cal.com/[]' and not 'cal.com/[]'

[keithwillcode]

@hariombalhara @Udit-takkar @zomars What do we need to do to move forward on this one?

[keithwillcode]

@zomars So merging this as is addresses @hariombalhara concerns?

[zomars]

Seems like we have regression of this fix #10172