cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: [app-router-migration 38]: Refactor migrated pages and fix generateMetadata functions

Open hbjORbj opened this issue 1 year ago • 2 comments

For some already migrated pages, we have the following problems:

  • generateMetadata is incorrect
  • we are not extracting getStaticProps / getServerSideProps into @lib and using it but rather duplicating the entire function in App Router pages

hbjORbj avatar Jan 18 '24 20:01 hbjORbj

@hbjORbj is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 18 '24 20:01 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 18 '24 20:01 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 6:49pm

vercel[bot] avatar Jan 22 '24 18:01 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jan 22 '24 18:01 github-actions[bot]

Production build is failing

@zomars Fixed it!

hbjORbj avatar Jan 22 '24 19:01 hbjORbj