cal.com
cal.com copied to clipboard
calcom
fix: add missing title
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/settings/my-account/out-of-office |
269.62 KB |
457.76 KB | 130.79% (🟢 -1.76%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
Thanks @anikdhabal 🙏 Left some comments.
Thanks for your review. Let me fix that quickly.
The title keeps changing back to Cal.com | Cal.com on other pages
Screen.Recording.2024-01-23.at.4.39.03.PM.mov
Thanks for the review. I've updated the code, and now everything is working fine.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 5, 2024 8:40pm |
Looks like this one consistently fails tests
So what am I going to do now? Also, those tests are not related to the changes.
@anikdhabal No, no worries. We'll look into getting the tests fixed.
Thank you.
this test "login flow user & logout using dashboard" is only failing in this PR. I see two sidebar when i run this E2E test locally on this branch.
this test "login flow user & logout using dashboard" is only failing in this PR. I see two sidebar when i run this E2E test locally on this branch.
Thanks for the review. I am on it.
Hey @Udit-takkar @keithwillcode two Layout is visible in future version.
The reason for having two layouts in future mode is that we wrap the component with getLayout. Therefore, we either have to ensure that all components in future mode are wrapped with shellmain, or we have to make getLayout null there. So that we can use shell as a parent.
I will update the code by today and ensure that everything is perfect in both the default and future modes.