cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: start and end date for ooo entry

Open CarinaWolli opened this issue 1 year ago • 4 comments

What does this PR do?

Fixes issue with wrong start and end date shown for ooo entries. This was caused by two issues (both of them depended on the user's browser timezone):

  1. a correct date from the db was shown wrong in the UI
  2. date was saved wrong in the db

Fixes #13268

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

CarinaWolli avatar Jan 17 '24 16:01 CarinaWolli

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 4:06am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 4:06am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 4:06am
cal ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 4:06am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 4:06am
qa ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 4:06am
ui ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 4:06am

vercel[bot] avatar Jan 17 '24 16:01 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 17 '24 16:01 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jan 17 '24 16:01 github-actions[bot]

Current Playwright Test Results Summary

✅ 399 Passing - ⚠️ 14 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/19/2024 03:58:57am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 288cd0a8373fd4d6bc0f4cdd1d79f5859942e1aa

Started: 01/19/2024 03:52:15am UTC

⚠️ Flakes

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user Time slots should be reserved when selected
Retry 1Initial Attempt
0% (0) 0 / 337 runs
failed over last 7 days
4.45% (15) 15 / 337 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully login flow user & logout using dashboard
Retry 1Initial Attempt
0.89% (3) 3 / 338 runs
failed over last 7 days
4.44% (15) 15 / 338 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1Initial Attempt
0% (0) 0 / 380 runs
failed over last 7 days
2.63% (10) 10 / 380 runs
flaked over last 7 days

📄   apps/web/playwright/payment-apps.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Payment app when more than one payment app is installed the price should be updated when changing settings
Retry 1Initial Attempt
0.82% (3) 3 / 364 runs
failed over last 7 days
4.67% (17) 17 / 364 runs
flaked over last 7 days

📄   apps/web/playwright/insights.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Insights should be able to go to insights as members
Retry 1Initial Attempt
0% (0) 0 / 359 runs
failed over last 7 days
3.34% (12) 12 / 359 runs
flaked over last 7 days

📄   apps/web/playwright/booking/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check availability tab in a event-type Check availability in event type
Retry 1Initial Attempt
32.61% (45) 45 / 138 runs
failed over last 7 days
24.64% (34) 34 / 138 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
2.06% (8) 8 / 389 runs
failed over last 7 days
55.53% (216) 216 / 389 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-8.13% (-26) -26 / 320 runs
failed over last 7 days
88.75% (284) 284 / 320 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-20.38% (-65) -65 / 319 runs
failed over last 7 days
53.92% (172) 172 / 319 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-18.81% (-60) -60 / 319 runs
failed over last 7 days
20.38% (65) 65 / 319 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-15.99% (-51) -51 / 319 runs
failed over last 7 days
79.94% (255) 255 / 319 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-19.18% (-61) -61 / 318 runs
failed over last 7 days
20.13% (64) 64 / 318 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-17.92% (-57) -57 / 318 runs
failed over last 7 days
20.13% (64) 64 / 318 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-19.11% (-60) -60 / 314 runs
failed over last 7 days
20.38% (64) 64 / 314 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Jan 17 '24 16:01 deploysentinel[bot]