cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Disallow next month prefetching in booker

Open keithwillcode opened this issue 1 year ago • 4 comments

What does this PR do?

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • [ ] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

keithwillcode avatar Jan 17 '24 16:01 keithwillcode

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 5:38pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 5:38pm
qa 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 5:38pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2024 5:38pm
cal ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2024 5:38pm
cal-demo ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2024 5:38pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2024 5:38pm
ui ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2024 5:38pm

vercel[bot] avatar Jan 17 '24 16:01 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 17 '24 16:01 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 263.87 KB 451.57 KB 129.02% (🟡 +0.16%)
/[user]/[type]/embed 263.9 KB 451.6 KB 129.03% (🟡 +0.16%)
/d/[link]/[slug] 263.71 KB 451.41 KB 128.97% (🟡 +0.17%)
/org/[orgSlug]/[user]/[type] 264.11 KB 451.8 KB 129.09% (🟡 +0.16%)
/org/[orgSlug]/[user]/[type]/embed 264.13 KB 451.83 KB 129.09% (🟡 +0.17%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 263.73 KB 451.42 KB 128.98% (🟡 +0.16%)
/org/[orgSlug]/team/[slug]/[type] 263.76 KB 451.45 KB 128.99% (🟡 +0.16%)
/team/[slug]/[type] 263.73 KB 451.42 KB 128.98% (🟡 +0.16%)
/team/[slug]/[type]/embed 263.75 KB 451.45 KB 128.99% (🟡 +0.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Jan 17 '24 16:01 github-actions[bot]

Current Playwright Test Results Summary

✅ 84 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/25/2024 05:46:06pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: bc510235d3835b223d68863160b58709ad42f750

Started: 01/25/2024 05:41:01pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2Retry 1Initial Attempt
2.27% (8) 8 / 353 runs
failed over last 7 days
37.68% (133) 133 / 353 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
38.12% (69) 69 / 181 runs
failed over last 7 days
32.60% (59) 59 / 181 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Jan 17 '24 16:01 deploysentinel[bot]

Hey there, there is a merge conflict, can you take a look?

github-actions[bot] avatar Jan 23 '24 05:01 github-actions[bot]