cal.com
cal.com copied to clipboard
calcom
fix: Allow impersonation from the /settings/admin/users page
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
hi @Udit-takkar and @anikdhabal, the functionality works, but when you click the impersonate button, it routes you to: /settings/admin/users as the new user. Which they would not have permission to. also, I don't think the VenetianMask is the standard Icon to use for Impersonation
hi @Udit-takkar and @anikdhabal, the functionality works, but when you click the impersonate button, it routes you to: /settings/admin/users as the new user. Which they would not have permission to. also, I don't think the VenetianMask is the standard Icon to use for Impersonation
Thanks for the review. I've fixed that. @Udit-takkar @PeerRich
https://github.com/calcom/cal.com/assets/81948346/2b11f7d1-d4f5-416a-9586-06c46fa246c4
But it's working fine for me @Udit-takkar.
@anikdhabal could you also add the modal like in the /teams? I re review this again or ask someone else to confirm
@anikdhabal could you also add the modal like in the /teams? I re review this again or ask someone else to confirm
Ok Let me quickly add that.
https://github.com/calcom/cal.com/assets/81948346/811aaf39-d393-4bd5-91bc-2fa8b902968a
@Udit-takkar