cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: navbar bottom width mobile fix

Open ivinayakg opened this issue 2 years ago • 5 comments

What does this PR do?

  • The parent having px-2 is breaking the navbar bottom in mobile dues to it having position:fixed, the change is to remove px-2 from the parent and add it to all its children except the navbar.

Fixes #13264

Loom Video: https://www.loom.com/share/eb16ba8ceb9b46ba9ad5a4736c3d04c9?sid=edb1efdb-329b-4e8b-b72a-7d9b306c46b1

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Just open cal.com on prod or on local and navigate to / with an authenticated user.

Mandatory Tasks

  • [ x ] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works

ivinayakg avatar Jan 16 '24 20:01 ivinayakg

@ivinayakg is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 16 '24 20:01 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 16 '24 20:01 CLAassistant

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 16 '24 20:01 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jan 16 '24 20:01 github-actions[bot]

Hey, @PeerRich thanks for the commit. Though there is one problem the EventTypeList component does not have its padding. image

I tried logging the props.flexChildrenContainer but it comes as undefined.

MainContainer from features/shell/Shell.tsx is the component rendering the component. image

I can't find where this component is given its props.

ivinayakg avatar Jan 17 '24 07:01 ivinayakg