cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: instant meeting improvements

Open Udit-takkar opened this issue 6 months ago • 4 comments

What does this PR do?

Fixes https://github.com/calcom/cal.com/issues/13174

  • Display team members pfp
  • a countdown of 60 seconds
  • Afterwards: "Oops, we couldn't connect you this time. Please schedule a future call instead"
  • lets block "closing tab" while waiting
  • Add option to add webhook in Switch
Screenshot 2024-01-16 at 8 23 57 PM

Webhooks

https://github.com/calcom/cal.com/assets/53316345/de6ca1ac-0e17-4b52-af75-3fd03cf9e712

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)

Udit-takkar avatar Jan 16 '24 14:01 Udit-takkar

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:43pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:43pm
qa 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:43pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 5:43pm
cal ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 5:43pm
cal-demo ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 5:43pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 5:43pm
ui ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 5:43pm

vercel[bot] avatar Jan 16 '24 14:01 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 16 '24 14:01 github-actions[bot]

No failed tests 🎉

deploysentinel[bot] avatar Jan 16 '24 15:01 deploysentinel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eighty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 263.39 KB 429.46 KB 122.70% (🟡 +0.42%)
/[user]/[type]/embed 263.42 KB 429.49 KB 122.71% (🟡 +0.42%)
/apps 270.63 KB 436.7 KB 124.77% (🟡 +0.34%)
/apps/[slug] 288.34 KB 454.41 KB 129.83% (🟡 +0.34%)
/apps/[slug]/[...pages] 547.99 KB 714.06 KB 204.02% (🟡 +0.33%)
/apps/categories 248.58 KB 414.65 KB 118.47% (🟡 +0.34%)
/apps/categories/[category] 252.85 KB 418.92 KB 119.69% (🟡 +0.34%)
/apps/installed/[category] 271.95 KB 438.01 KB 125.15% (🟡 +0.33%)
/availability 425.11 KB 591.17 KB 168.91% (🟡 +0.33%)
/availability/[schedule] 352.34 KB 518.41 KB 148.12% (🟡 +0.33%)
/availability/troubleshoot 171.29 KB 337.36 KB 96.39% (🟡 +0.34%)
/booking/[uid] 190.77 KB 356.83 KB 101.95% (🟡 +0.34%)
/booking/[uid]/embed 190.84 KB 356.9 KB 101.97% (🟡 +0.34%)
/bookings/[status] 316.33 KB 482.39 KB 137.83% (🟡 +0.33%)
/d/[link]/[slug] 263.24 KB 429.3 KB 122.66% (🟡 +0.42%)
/enterprise 249.05 KB 415.12 KB 118.61% (🟡 +0.33%)
/event-types 546.46 KB 712.53 KB 203.58% (🟡 +0.34%)
/event-types/[type] 422.13 KB 588.2 KB 168.06% (🟡 +0.34%)
/getting-started/[[...step]] 403.56 KB 569.63 KB 162.75% (🟡 +0.34%)
/insights 474.86 KB 640.92 KB 183.12% (🟡 +0.34%)
/more 248.21 KB 414.28 KB 118.37% (🟡 +0.33%)
/org/[orgSlug] 229.62 KB 395.69 KB 113.05% (🟡 +0.34%)
/org/[orgSlug]/[user] 236.12 KB 402.19 KB 114.91% (🟡 +0.34%)
/org/[orgSlug]/[user]/[type] 263.63 KB 429.7 KB 122.77% (🟡 +0.42%)
/org/[orgSlug]/[user]/[type]/embed 263.66 KB 429.72 KB 122.78% (🟡 +0.42%)
/org/[orgSlug]/[user]/embed 236.15 KB 402.21 KB 114.92% (🟡 +0.33%)
/org/[orgSlug]/embed 229.64 KB 395.71 KB 113.06% (🟡 +0.33%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 263.25 KB 429.32 KB 122.66% (🟡 +0.42%)
/org/[orgSlug]/team/[slug] 229.63 KB 395.7 KB 113.06% (🟡 +0.33%)
/org/[orgSlug]/team/[slug]/[type] 263.28 KB 429.35 KB 122.67% (🟡 +0.42%)
/payment/[uid] 117.78 KB 283.84 KB 81.10% (🟡 +0.34%)
/settings/admin 254.89 KB 420.96 KB 120.27% (🟡 +0.34%)
/settings/admin/apps 268.15 KB 434.22 KB 124.06% (🟡 +0.34%)
/settings/admin/apps/[category] 268.14 KB 434.21 KB 124.06% (🟡 +0.33%)
/settings/admin/flags 258.65 KB 424.72 KB 121.35% (🟡 +0.34%)
/settings/admin/impersonation 255.19 KB 421.26 KB 120.36% (🟡 +0.34%)
/settings/admin/oAuth 266.91 KB 432.97 KB 123.71% (🟡 +0.33%)
/settings/admin/orgMigrations/_OrgMigrationLayout 247.66 KB 413.73 KB 118.21% (🟡 +0.33%)
/settings/admin/orgMigrations/moveTeamToOrg 264.43 KB 430.49 KB 123.00% (🟡 +0.33%)
/settings/admin/orgMigrations/moveUserToOrg 282.88 KB 448.95 KB 128.27% (🟡 +0.34%)
/settings/admin/orgMigrations/removeTeamFromOrg 264.18 KB 430.25 KB 122.93% (🟡 +0.34%)
/settings/admin/orgMigrations/removeUserFromOrg 264.2 KB 430.26 KB 122.93% (🟡 +0.34%)
/settings/admin/organizations 256.92 KB 422.98 KB 120.85% (🟡 +0.34%)
/settings/admin/organizations/[id]/edit 255.41 KB 421.48 KB 120.42% (🟡 +0.34%)
/settings/admin/users 257.6 KB 423.67 KB 121.05% (🟡 +0.34%)
/settings/admin/users/[id]/edit 357.07 KB 523.13 KB 149.47% (🟡 +0.33%)
/settings/admin/users/add 356.8 KB 522.87 KB 149.39% (🟡 +0.34%)
/settings/billing 255.1 KB 421.17 KB 120.33% (🟡 +0.34%)
/settings/developer/api-keys 259.51 KB 425.58 KB 121.59% (🟡 +0.34%)
/settings/developer/webhooks 259.43 KB 425.5 KB 121.57% (🟡 +0.34%)
/settings/developer/webhooks/[id] 260.49 KB 426.56 KB 121.87% (🟡 +0.35%)
/settings/developer/webhooks/new 260.53 KB 426.6 KB 121.89% (🟡 +0.34%)
/settings/my-account/appearance 278.6 KB 444.67 KB 127.05% (🟡 +0.33%)
/settings/my-account/calendars 265.87 KB 431.94 KB 123.41% (🟡 +0.34%)
/settings/my-account/conferencing 266.73 KB 432.8 KB 123.66% (🟡 +0.33%)
/settings/my-account/general 343.22 KB 509.28 KB 145.51% (🟡 +0.34%)
/settings/my-account/out-of-office 259.31 KB 425.38 KB 121.54% (🟡 +0.33%)
/settings/my-account/profile 392.19 KB 558.26 KB 159.50% (🟡 +0.34%)
/settings/organizations/appearance 278.48 KB 444.55 KB 127.01% (🟡 +0.34%)
/settings/organizations/billing 255.13 KB 421.2 KB 120.34% (🟡 +0.34%)
/settings/organizations/general 335.75 KB 501.82 KB 143.38% (🟡 +0.33%)
/settings/organizations/members 422.33 KB 588.4 KB 168.11% (🟡 +0.34%)
/settings/organizations/profile 389.2 KB 555.27 KB 158.65% (🟡 +0.33%)
/settings/organizations/teams/other 255.96 KB 422.03 KB 120.58% (🟡 +0.34%)
/settings/organizations/teams/other/[id]/appearance 267.56 KB 433.63 KB 123.89% (🟡 +0.34%)
/settings/organizations/teams/other/[id]/members 262.21 KB 428.28 KB 122.36% (🟡 +0.34%)
/settings/organizations/teams/other/[id]/profile 460.81 KB 626.87 KB 179.11% (🟡 +0.33%)
/settings/security/impersonation 260.19 KB 426.26 KB 121.79% (🟡 +0.34%)
/settings/security/password 269.15 KB 435.21 KB 124.35% (🟡 +0.33%)
/settings/security/sso 265.18 KB 431.25 KB 123.21% (🟡 +0.34%)
/settings/security/two-factor-auth 264.02 KB 430.08 KB 122.88% (🟡 +0.34%)
/settings/teams 254.63 KB 420.7 KB 120.20% (🟡 +0.34%)
/settings/teams/[id]/appearance 267.55 KB 433.61 KB 123.89% (🟡 +0.34%)
/settings/teams/[id]/billing 255.14 KB 421.2 KB 120.34% (🟡 +0.34%)
/settings/teams/[id]/members 381.1 KB 547.17 KB 156.33% (🟡 +0.34%)
/settings/teams/[id]/profile 461.63 KB 627.69 KB 179.34% (🟡 +0.34%)
/settings/teams/[id]/sso 265.7 KB 431.76 KB 123.36% (🟡 +0.34%)
/signup 147.79 KB 313.86 KB 89.67% (🟡 +0.34%)
/team/[slug] 229.58 KB 395.65 KB 113.04% (🟡 +0.34%)
/team/[slug]/[type] 263.25 KB 429.32 KB 122.66% (🟡 +0.42%)
/team/[slug]/[type]/embed 263.28 KB 429.34 KB 122.67% (🟡 +0.42%)
/team/[slug]/embed 229.63 KB 395.69 KB 113.06% (🟡 +0.33%)
/teams 248.49 KB 414.55 KB 118.44% (🟡 +0.34%)
/upgrade 248.66 KB 414.73 KB 118.49% (🟡 +0.34%)
/video/[uid] 234.51 KB 400.58 KB 114.45% (🟡 +0.34%)
/video/meeting-ended/[uid] 95.06 KB 261.13 KB 74.61% (🟡 +0.34%)
/video/meeting-not-started/[uid] 94.71 KB 260.77 KB 74.51% (🟡 +0.33%)
/workflows 286.93 KB 453 KB 129.43% (🟡 +0.33%)
/workflows/[workflow] 400.78 KB 566.84 KB 161.96% (🟡 +0.33%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Jan 16 '24 19:01 github-actions[bot]

Type-check is failing now and there are merge conflicts, can you take a look @Udit-takkar?

CarinaWolli avatar Jan 22 '24 15:01 CarinaWolli

@CarinaWolli Thanks for the ping. fixing it

Udit-takkar avatar Jan 22 '24 15:01 Udit-takkar