cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: disable input elements while updating the form

Open Krishcode264 opened this issue 1 year ago • 4 comments

What does this PR do?

Fixes #13111

i have added prop disabled={isLoading} for name and email and username used same logic to disable add avatar buttons while updating the form

what could have been better

if i could do same with "About" input but

  <ContentEditable
                  readOnly={!editable}
                  style={{ height: props.height }}
                  className="editor-input"
                />

even if i put readOnly={false } or {true } for dev purpose it does chnage anything its always editable

other than that all input fields are tested which are getting disabled while updating form

this is my first PR ever and i am getting some issues with yarn.lock which is not matching with orignal one , so please check it .

Krishcode264 avatar Jan 16 '24 09:01 Krishcode264

@Krishcode264 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 16 '24 09:01 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 16 '24 09:01 CLAassistant

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 16 '24 09:01 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jan 17 '24 06:01 github-actions[bot]

I am not a fan of having this flicker of gray input fields. @ciaranha what do you think about that: https://www.loom.com/share/549c87a1dbed4a7b87a3e1d2bfd827c3

Also not a fan of the flicker. It's drawing my attention to things I otherwise wouldn't look at. Not sure this a problem that needs solving.

ciaranha avatar Jan 19 '24 13:01 ciaranha