fix: When declining OAuth return to previous page

[joeauyeung]

What does this PR do?

This PR also takes some code from #12513

This PR aims to redirect users back to the page before they started the OAuth flow. Before it would just display a HTTP error.

Fixes #12602

https://www.loom.com/share/63289e3fae6343e8bfabe86a5aaf963e

Requirement/Documentation

• If there is a requirement document, please, share it here.
• If there is ab UI/UX design document, please, share it here.

Type of change

• From the app store, app page, and onboarding - For GCal, Outlook, and Stripe - Install the app - Cancel part way through the flow - You should be redirected back to the page you came from
• For GCal
  • Only grant one permission. The credential should not be created and you should return to the page you were at before

How should this be tested?

• Are there environment variables that should be set?
• What are the minimal test data to have?
• What is expected (happy path) to have (input and output)?
• Any other important info that could help to test that PR

Mandatory Tasks

• [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2024 11:16am
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2024 11:16am
dev	❌ Failed (Inspect)			Jan 27, 2024 11:16am

5 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jan 27, 2024 11:16am
cal-demo	⬜️ Ignored (Inspect)	Visit Preview		Jan 27, 2024 11:16am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Jan 27, 2024 11:16am
qa	⬜️ Ignored (Inspect)	Visit Preview		Jan 27, 2024 11:16am
ui	⬜️ Ignored (Inspect)	Visit Preview		Jan 27, 2024 11:16am

[github-actions[bot]]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[CarinaWolli]

production build is failing, also fails on local. @joeauyeung can you take a look at that?

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 430 Passing - ⚠️ 23 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/27/2024 11:20:46am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: cf9f3d518d2ce98f9bf6450ed8a8caec062c7db2

Started: 01/27/2024 11:13:02am UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email required and Phone required Retry 1 • Initial Attempt	0.40% (1) 1 / 252 run failed over last 7 days	3.57% (9) 9 / 252 runs flaked over last 7 days

---

📄   apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

null	13 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes Retry 1 • Initial Attempt	-18.47% (-46) -46 / 249 runs failed over last 7 days	18.88% (47) 47 / 249 runs flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes Retry 1 • Initial Attempt	-18.95% (-47) -47 / 248 runs failed over last 7 days	18.95% (47) 47 / 248 runs flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes Retry 1 • Initial Attempt	-19.03% (-47) -47 / 247 runs failed over last 7 days	19.03% (47) 47 / 247 runs flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes Retry 1 • Initial Attempt	-19.03% (-47) -47 / 247 runs failed over last 7 days	19.03% (47) 47 / 247 runs flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes Retry 1 • Initial Attempt	-18.62% (-46) -46 / 247 runs failed over last 7 days	19.03% (47) 47 / 247 runs flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes Retry 1 • Initial Attempt	-19.11% (-47) -47 / 246 runs failed over last 7 days	19.11% (47) 47 / 246 runs flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes Retry 1 • Initial Attempt	-19.11% (-47) -47 / 246 runs failed over last 7 days	19.11% (47) 47 / 246 runs flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes Retry 1 • Initial Attempt	-19.11% (-47) -47 / 246 runs failed over last 7 days	19.11% (47) 47 / 246 runs flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes Retry 1 • Initial Attempt	-19.18% (-47) -47 / 245 runs failed over last 7 days	19.18% (47) 47 / 245 runs flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes Retry 1 • Initial Attempt	-19.18% (-47) -47 / 245 runs failed over last 7 days	19.18% (47) 47 / 245 runs flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-19.18% (-47) -47 / 245 runs failed over last 7 days	19.18% (47) 47 / 245 runs flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-6.61% (-16) -16 / 242 runs failed over last 7 days	16.12% (39) 39 / 242 runs flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes Retry 1 • Initial Attempt	-8.22% (-18) -18 / 219 runs failed over last 7 days	17.35% (38) 38 / 219 runs flaked over last 7 days

---

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	4.08% (10) 10 / 245 runs failed over last 7 days	38.37% (94) 94 / 245 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/availability.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Check availability tab in a event-type Check availability in event type Retry 1 • Initial Attempt	20.16% (51) 51 / 253 runs failed over last 7 days	41.50% (105) 105 / 253 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking page with no questions Booking page with 640x480 resolution Retry 1 • Initial Attempt	1.03% (1) 1 / 97 run failed over last 7 days	3.09% (3) 3 / 97 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox group Question Select required and checkbox group required Retry 1 • Initial Attempt	0% (0) 0 / 244 runs failed over last 7 days	1.64% (4) 4 / 244 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Short text question Radio required and Short text required Retry 1 • Initial Attempt	0.41% (1) 1 / 245 run failed over last 7 days	3.67% (9) 9 / 245 runs flaked over last 7 days

---

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user enabling recurring event comes with default options Retry 1 • Initial Attempt	0.40% (1) 1 / 252 run failed over last 7 days	11.11% (28) 28 / 252 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Radio group Question Phone and Radio group required Retry 1 • Initial Attempt	0% (0) 0 / 251 runs failed over last 7 days	3.19% (8) 8 / 251 runs flaked over last 7 days

---

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Checkbox Group Question Address required and checkbox group required Retry 1 • Initial Attempt	2.94% (8) 8 / 272 runs failed over last 7 days	3.31% (9) 9 / 272 runs flaked over last 7 days

---

📄   apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events Retry 1 • Initial Attempt	0.39% (1) 1 / 258 run failed over last 7 days	10.47% (27) 27 / 258 runs flaked over last 7 days

---

View Detailed Build Results

---