cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-2980] Adding a date override requires two clicks

Open steven-tey opened this issue 1 year ago • 5 comments

Surprised this is required since when you click on "Add override", the toast says "Override added", but then if you refresh the page it disappears. You need to click on the general "Save" button for it to work.

CleanShot 2024-01-09 at 19 19 45

From SyncLinear.com | CAL-2980

steven-tey avatar Jan 10 '24 03:01 steven-tey

want to solve this

adityaDev100 avatar Jan 10 '24 06:01 adityaDev100

Hey @steven-tey, I believe some clarification from a Core member would be beneficial here. It seems like the Add Override functionality specifically updates the UI content upon clicking the button, with success messages displayed. However, it appears that this new data modifies the frontend value only. To make these changes permanent, the Save button is utilized to transmit the updated data to the backend for the actual update. Looking forward to insights from the Core team on this! 🚀

Piyush-Kumar-Ghosh avatar Jan 10 '24 07:01 Piyush-Kumar-Ghosh

i agree. adding an override should also save the new availability without extra clicking "Save"

PeerRich avatar Jan 10 '24 18:01 PeerRich

Hi @PeerRich, I would like to attempt it.

Piyush-Kumar-Ghosh avatar Jan 10 '24 19:01 Piyush-Kumar-Ghosh

After adding an override and navigating away, there wasn't a warning about losing the override. After adding many overrides, I got caught up with that and lost all my progress. That was confusing/annoying. If not saving the override after the modal closes, can we at least get a warning when navigating away?

dariuspirvulescu avatar Feb 27 '24 11:02 dariuspirvulescu