cal.com
cal.com copied to clipboard
fix: drag and drop the event List
What does this PR do?
Fixes #13067
https://github.com/calcom/cal.com/assets/8019099/3c2a53f5-dfc7-438a-98d4-3b5dee66f2e2
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Chore (refactoring code, technical debt, workflow improvements)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Tests (Unit/Integration/E2E or any other test)
- [ ] This change requires a documentation update
Mandatory Tasks
- [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
@Airbornharsh is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/auth/oauth2/authorize |
117.36 KB |
282.12 KB | 80.61% (🟢 -0.17%) |
/event-types |
546.19 KB |
710.95 KB | 203.13% (🟡 +0.16%) |
/getting-started/[[...step]] |
403.93 KB |
568.7 KB | 162.49% (🟢 -0.17%) |
/settings/teams/[id]/members |
380.38 KB |
545.15 KB | 155.76% (🟡 +0.25%) |
/settings/teams/[id]/onboard-members |
157.11 KB |
321.87 KB | 91.96% (🟢 -0.17%) |
/settings/teams/new |
189.78 KB |
354.54 KB | 101.30% (🟢 -0.17%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| dev | ❌ Failed (Inspect) | Jan 11, 2024 10:30am |
also there is a slight delay after dropping where the container goes back to its old position and then moves to the correct position
@PeerRich
https://github.com/calcom/cal.com/assets/95279849/ca1638e6-6974-48f1-a45f-50a5f3ff0b55
Added Drag on the Element and there was no delay in Dragging
I was referring on adding the grab event only on the up and down buttons:
<ArrowButton onClick={() => moveEventType(index, 1)} arrowDirection="down" />
the normal <li> should not have the grab functionality and not the grab cursor
@PeerRich OK I will Update it
@Airbornharsh let me know if you need help
@PeerRich I have Added Drag in the arrow, you can Review it
@PeerRich the issue has been marked "not planned". do we need this?
Hey there, there is a merge conflict, can you take a look?
Closing based on @PeerRich comments on the referenced issue.