feat: impersonation improvements

[sean-brydon]

trafficstars

What does this PR do?

Fixes SAL-77

Loom Video: https://www.loom.com/share/9f69dec44bb74677838038bd4982bf7f

Requirement/Documentation

• If there is a requirement document, please, share it here.
• If there is ab UI/UX design document, please, share it here.

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Chore (refactoring code, technical debt, workflow improvements)
• [X] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [X] Tests (Unit/Integration/E2E or any other test)
• [ ] This change requires a documentation update

How should this be tested?

1. Login as admin -> impersonate user -> return to admin
2. Login as account connected to org -> impersonate member -> return to org account
3. Login as team owner -> impersonate member -> logged out

[linear[bot]]

SAL-77 Impersonating without being Logged Out

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 16, 2024 8:32am
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 16, 2024 8:32am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 16, 2024 8:32am

4 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jan 16, 2024 8:32am
cal-demo	⬜️ Ignored (Inspect)	Visit Preview		Jan 16, 2024 8:32am
qa	⬜️ Ignored (Inspect)	Visit Preview		Jan 16, 2024 8:32am
ui	⬜️ Ignored (Inspect)	Visit Preview		Jan 16, 2024 8:32am

[github-actions[bot]]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[pumfleet]

Wow this looks like a way snappier experience! I love it

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 380 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/16/2024 08:43:54am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7d003976292a3dd98aea2d3b0c33b1d2d975a092

Started: 01/16/2024 08:33:59am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	0% (0) 0 / 259 runs failed over last 7 days	35.14% (91) 91 / 259 runs flaked over last 7 days

---

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Team invitation Retry 1 • Initial Attempt	5.54% (21) 21 / 379 runs failed over last 7 days	27.70% (105) 105 / 379 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null	3 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	13.39% (51) 51 / 381 runs failed over last 7 days	82.41% (314) 314 / 381 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-2.11% (-8) -8 / 380 runs failed over last 7 days	43.95% (167) 167 / 380 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	2.63% (10) 10 / 380 runs failed over last 7 days	76.58% (291) 291 / 380 runs flaked over last 7 days

---

📄   apps/web/playwright/oauth-provider.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
OAuth Provider should create valid access token & refresh token for team Retry 1 • Initial Attempt	0% (0) 0 / 386 runs failed over last 7 days	17.10% (66) 66 / 386 runs flaked over last 7 days

---

View Detailed Build Results

---

[Udit-takkar]

@sean-brydon works great. some type checks are failing and E2E tests (don't seem related to changes in this PR).