cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: [app-router-migration 27] migrate the "signup" page

Open grzpab opened this issue 2 years ago • 5 comments

What does this PR do?

  • This PR migrates the /signup page to the app directory (which runs under the App Router).
  • The migrated page exists under /future/signup and is accessible at all times.
  • We support a redirect from the former to the latter with the middleware and environmental variables, as done previously.

Type of change

  • [X] Chore (refactoring code, technical debt, workflow improvements)
  • [X] New feature (non-breaking change which adds functionality)

How should this be tested?

There should be no changes between the /signup and /future/signup in terms of performance and content (on Lighthouse both pages get near 100 scores).

If the APP_ROUTER_SIGNUP_ENABLED is set to 1 and AB_TEST_BUCKET_PROBABILITY is set to 100, then the future signup page should be rendered in place of the /signup page WITHOUT a visible redirect. We can see it by inspecting the existence of the x-calcom-future-routes-enabled cookie.

Mandatory Tasks

  • [X] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

grzpab avatar Jan 05 '24 16:01 grzpab

@grzpab is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 05 '24 16:01 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 05 '24 16:01 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jan 05 '24 17:01 github-actions[bot]

whats needed here to leave draft @grzpab

PeerRich avatar Jan 08 '24 12:01 PeerRich

@PeerRich Sorry for the delay. We got it ready now. @grzpab will turn it ready for review soon.

hbjORbj avatar Jan 15 '24 13:01 hbjORbj