cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

test: Create E2E tests for bookings with custom/required Multi Select + other questions (teste2e-multiSelectQuestion)

Open gitstart-app[bot] opened this issue 2 years ago • 10 comments

HOW TO RUN THE TESTS

Run

yarn e2e multiSelectQuestion

DEMO

image

gitstart-app[bot] avatar Sep 27 '23 23:09 gitstart-app[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 4:04pm
dev ❌ Failed (Inspect) Feb 8, 2024 4:04pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 4:04pm
cal ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 4:04pm
cal-demo ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 4:04pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 4:04pm
qa ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 4:04pm
ui ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 4:04pm

vercel[bot] avatar Sep 27 '23 23:09 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Sep 27 '23 23:09 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Sep 27 '23 23:09 github-actions[bot]

Current Playwright Test Results Summary

✅ 442 Passing - ⚠️ 22 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/08/2024 04:24:06pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 28be897c89d52062d6f69da134ff03da49fa90a1

Started: 02/08/2024 04:14:21pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and multiselect Question Multiple Email and multiselect text not required
Retry 1Initial Attempt
0.31% (1) 1 / 321 run
failed over last 7 days
3.74% (12) 12 / 321 runs
flaked over last 7 days
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email and Phone not required
Retry 1Initial Attempt
0% (0) 0 / 318 runs
failed over last 7 days
5.03% (16) 16 / 318 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
prefill -- future logged in
Retry 1Initial Attempt
0% (0) 0 / 294 runs
failed over last 7 days
3.40% (10) 10 / 294 runs
flaked over last 7 days

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Short text question Checkbox Group required and Short Text required
Retry 2Retry 1Initial Attempt
0% (0) 0 / 325 runs
failed over last 7 days
5.23% (17) 17 / 325 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
4.98% (16) 16 / 321 runs
failed over last 7 days
37.69% (121) 121 / 321 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Paid booking should be able to be rescheduled
Retry 1Initial Attempt
2.11% (7) 7 / 332 runs
failed over last 7 days
4.82% (16) 16 / 332 runs
flaked over last 7 days
Stripe integration Paid booking should be able to be cancelled
Retry 1Initial Attempt
0% (0) 0 / 329 runs
failed over last 7 days
3.65% (12) 12 / 329 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and select Question Radio required and select required
Retry 1Initial Attempt
0% (0) 0 / 321 runs
failed over last 7 days
5.61% (18) 18 / 321 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Webhook tests FORM_SUBMITTED on submitting user form, triggers user webhook
Retry 1Initial Attempt
1.81% (6) 6 / 331 runs
failed over last 7 days
4.83% (16) 16 / 331 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation
Retry 1Initial Attempt
12.65% (42) 42 / 332 runs
failed over last 7 days
9.04% (30) 30 / 332 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Multi email Question Phone required and Multi email not required
Retry 1Initial Attempt
0.30% (1) 1 / 331 run
failed over last 7 days
5.14% (17) 17 / 331 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
20.63% (13) 13 / 63 runs
failed over last 7 days
50.79% (32) 32 / 63 runs
flaked over last 7 days
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1Initial Attempt
0% (0) 0 / 53 runs
failed over last 7 days
56.60% (30) 30 / 53 runs
flaked over last 7 days

📄   apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1Initial Attempt
0.88% (3) 3 / 341 runs
failed over last 7 days
7.62% (26) 26 / 341 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-1.77% (-6) -6 / 339 runs
failed over last 7 days
52.80% (179) 179 / 339 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-108.48% (-179) -179 / 165 runs
failed over last 7 days
108.48% (179) 179 / 165 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-98.79% (-163) -163 / 165 runs
failed over last 7 days
100.61% (166) 166 / 165 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-102.47% (-166) -166 / 162 runs
failed over last 7 days
102.47% (166) 166 / 162 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-101.85% (-165) -165 / 162 runs
failed over last 7 days
101.85% (165) 165 / 162 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-102.47% (-166) -166 / 162 runs
failed over last 7 days
102.47% (166) 166 / 162 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-101.85% (-165) -165 / 162 runs
failed over last 7 days
101.85% (165) 165 / 162 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-101.85% (-165) -165 / 162 runs
failed over last 7 days
101.85% (165) 165 / 162 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Sep 27 '23 23:09 deploysentinel[bot]

Hi @ThyMinimalDev @keithwillcode we made the changes here, please take a look 😄

gitstart-calcom avatar Oct 24 '23 14:10 gitstart-calcom

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Dec 13 '23 00:12 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Dec 25 '23 00:12 github-actions[bot]

@keithwillcode would love to get your thoughts but maybe this can be reduced to unit tests? It feels like we can test the functions that get the options for the multi select.

joeauyeung avatar Jan 19 '24 20:01 joeauyeung

@keithwillcode would love to get your thoughts but maybe this can be reduced to unit tests? It feels like we can test the functions that get the options for the multi select.

Yeah I like this idea. Otherwise, this PR feels too bulky and repetitive for the value we are getting from it.

keithwillcode avatar Jan 19 '24 21:01 keithwillcode

@keithwillcode @joeauyeung Makes sense, we can provide unit tests for all question combinations, this will reduce the E2E tests for that cases

gitstart-calcom avatar Jan 21 '24 19:01 gitstart-calcom

Hi @keithwillcode just to make sure, should we start to work on these unit tests?

gitstart-calcom avatar Jan 28 '24 22:01 gitstart-calcom

Hi @keithwillcode just to make sure, should we start to work on these unit tests?

Yeah let’s do it

keithwillcode avatar Jan 29 '24 00:01 keithwillcode

@keithwillcode @joeauyeung We changed the tests to a unit test file covering all questions, please take a look 😄

gitstart-calcom avatar Feb 07 '24 20:02 gitstart-calcom