bug: `Reject` button in email rejects the booking without popup

[juliusmarminge]

Found a bug? Please fill out the sections below. 👍

Issue Summary

A summary of the issue. This needs to be a clear detailed-rich summary.

Steps to Reproduce

1. Get a booking from someone
2. Click reject in the email
3. You'll get taken to the rejection page immediately, without the confirm button or a chance to put a reason for the rejection, which you do get on the app

Actual Results

• What's happening right now that is different from what is expected

The booking is rejected immediately when I click the button in the email

Expected Results

It should be prompting me to confirm and add an (optional) reason, just like it does in the app

Technical details

• Browser version, screen recording, console logs, network requests: You can make a recording with Bird Eats Bug.
• Node.js version
• Anything else that you think could be an issue.

Evidence

Email:

https://github.com/calcom/cal.com/assets/51714798/9a86bafe-d4e9-4c36-bcb4-5b50478e8424

App:

https://github.com/calcom/cal.com/assets/51714798/e1759471-2051-4526-a45f-acf616bd726c

[prayagcbose]

https://github.com/calcom/cal.com/assets/47104455/89dabc76-6a0e-4926-88b2-3632c99154ed

Steps I took to reproduce:

1. created a booking
2. In the email I clicked on cancel button

I'm getting the option to add a reason for cancellation. It's not directly cancelling the booking. Could you please clarify if I'm on the right track to reproduce this issue or not?

[Subhojit-Dey1234]

I have tried it locally. It redirects to the cancelation page only.

[juliusmarminge]

The cancel button in your email looks different than my Reject button

[prayagcbose]

Ok Found the issue. Steps to reproduce: When creating a booking, Requires confirmation must be set as always.

Now I'm getting the Reject option in my email.

Proposed solution 1:

When the user clicks reject we redirect to a page similar to the case when the user cancels the booking.

Proposed solution 2:

When the user clicks reject we redirect to the booking/upcoming page with the pop-up pre-opened.

Please suggest which solution should be followed. Also please suggest if any alternate solution exists.

[PeerRich]

yes i agree, this is a better solution!

[juliusmarminge]

Solution 2 is what I'd do

[piannaf]

My company is new to cal.com and we just tested the Reject flow. Definitely agree that one of these proposed solution should be implemented. It's too jarring for our customers to get a "Your event has been declined" message without a reason.

I noticed @PeerRich set this as Low priority. We are using this feature in email campaigns and want to be able to vet bookings before accepting them. Just limiting the number of bookings per day/week/month isn't appropriate because we want to accept the highest value bookings rather than first-come-first-serve. Hope to see this enhanced soon. Thanks!

[piannaf]

Oh, I just figured out why this can be Low priority: rejecting via email isn't the only way to reject. I found that we can reject from the booking page and it pops up the "Reason for rejecting" modal in "Proposed solution 2". We'll be sure to use that rejection flow instead of straight from the email for now.