cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: slack app

Open rkreddy99 opened this issue 2 years ago • 16 comments
trafficstars

What does this PR do?

Create slack app for notifications

Fixes #10683

Loom Video: https://www.loom.com/share/c7761e726ecd4db69116c6fa0f65a128

Type of change

  • [x] New feature (non-breaking change which adds functionality)

How should this be tested?

  • Create a bot app in slack for messaging
  • Install slack in Cal.com by providing valid credentials
  • Book a meeting, message should appear in the channel

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

/claim #10683

edit - updated the video link

rkreddy99 avatar Aug 10 '23 18:08 rkreddy99

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Aug 10 '23 18:08 github-actions[bot]

todo: ~have to move credentials to DB. The attached creds in the PR are fake.~ ~bug - slack is not being showed in the installed apps~

rkreddy99 avatar Aug 10 '23 18:08 rkreddy99

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 7:43pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 7:43pm

vercel[bot] avatar Aug 10 '23 18:08 vercel[bot]

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 10 '23 18:08 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Aug 10 '23 18:08 github-actions[bot]

~working on~

  • ~updating the notification content to be sent~
  • ~how to use correct slack webhook url when there are multiple installations~

rkreddy99 avatar Aug 12 '23 06:08 rkreddy99

Here's the updated video

https://www.loom.com/share/c7761e726ecd4db69116c6fa0f65a128

cc @PeerRich

rkreddy99 avatar Aug 13 '23 14:08 rkreddy99

if the issue still open, please give me a chance to fix the issue

KSSaiTeja avatar Aug 23 '23 07:08 KSSaiTeja

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
18 out of 20 committers have signed the CLA.

:white_check_mark: leog
:white_check_mark: joeauyeung
:white_check_mark: emrysal
:white_check_mark: Udit-takkar
:white_check_mark: gitstart-calcom
:white_check_mark: p6l-richard
:white_check_mark: Hitesh-Sisara
:white_check_mark: DexterStorey
:white_check_mark: vijayraghav-io
:white_check_mark: harsh11101
:white_check_mark: murtajaziad
:white_check_mark: ty-kerr
:white_check_mark: Dhoni77
:white_check_mark: shivamklr
:white_check_mark: rkreddy99
:white_check_mark: aar2dee2
:white_check_mark: keithwillcode
:white_check_mark: alannnc
:x: crowdin-bot
:x: samueldenzil
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 28 '23 09:08 CLAassistant

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

vercel[bot] avatar Sep 27 '23 04:09 vercel[bot]

Thanks for the PR @rkreddy99 🙏🏼

@hariombalhara request your confirmation for the suggestion below.

After setting up a bot in Slack, I receive notifications for booking created, but not for rescheduled or cancelled. I'd recommend setting up a webhook for each of these events. You can refer to the Make.com integration here on how to setup webhooks.

Also left some comments above.

aar2dee2 avatar Oct 02 '23 16:10 aar2dee2

working on the suggestions

rkreddy99 avatar Oct 10 '23 08:10 rkreddy99

hey @aar2dee2 can we connect on discord for the suggestions, had some doubts

rkreddy99 avatar Oct 21 '23 06:10 rkreddy99

hey @aar2dee2 can we connect on discord for the suggestions, had some doubts

Sure. Accepted your request.

aar2dee2 avatar Oct 23 '23 04:10 aar2dee2

@calcom/consumer lets take this over in 3.8 and push it across the line.

keithwillcode avatar Jan 20 '24 21:01 keithwillcode

Closing for now until we prio higher in a future release. cc @joeauyeung

keithwillcode avatar Jan 23 '24 10:01 keithwillcode