cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: UI mismatch with form state

Open MehulZR opened this issue 2 years ago • 11 comments

What does this PR do?

Fixes #10647 (issue) ~~Fixes #10390 (issue)~~

https://github.com/calcom/cal.com/assets/86384652/677e684f-b73b-4da9-a6dd-750ed8d85577

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

MehulZR avatar Aug 08 '23 22:08 MehulZR

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 3:48pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
calcom-web-canary ⬜️ Ignored (Inspect) Jan 23, 2024 3:48pm

vercel[bot] avatar Aug 08 '23 22:08 vercel[bot]

@MehulZR is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 08 '23 22:08 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Aug 08 '23 22:08 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Aug 08 '23 22:08 github-actions[bot]

@MehulZR Could you please remove the changes related to #10390 from this PR as that's already solved(and being solved) elsewhere already.

Also, you should open separate PRs for separate fixes unless they are really really related. It makes it easy to review and merge the PR

hariombalhara avatar Aug 14 '23 11:08 hariombalhara

While updating the PR, I noticed that it is possible to book a event with length of 0. This is possible when saving the form from a tab other than the Event Setup.

image

We can solve it in two ways.

  1. Either not letting the form submit via RHF.
  2. On Submit, checking the value and throwing an Error like we do when there are no multiple durations selected.

I prefer the 2nd approach because If we use the 1st approach The user will not get any indication of an error on tabs other than Event Setup. And it also looks more consistent.

If you would like the 2nd approach too. What Error message do you want to be shown?

image

MehulZR avatar Aug 14 '23 20:08 MehulZR

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 28 '23 09:08 CLAassistant

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Oct 13 '23 00:10 github-actions[bot]

@MehulZR can you fix the conflicts in this PR?

Udit-takkar avatar Oct 13 '23 07:10 Udit-takkar

@MehulZR just a heads up there's more conflicts

joeauyeung avatar Jan 19 '24 20:01 joeauyeung