cal.com
cal.com copied to clipboard
fix: UI mismatch with form state
What does this PR do?
Fixes #10647 (issue) ~~Fixes #10390 (issue)~~
https://github.com/calcom/cal.com/assets/86384652/677e684f-b73b-4da9-a6dd-750ed8d85577
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
Mandatory Tasks
- [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 23, 2024 3:48pm |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| calcom-web-canary | ⬜️ Ignored (Inspect) | Jan 23, 2024 3:48pm |
@MehulZR is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
@MehulZR Could you please remove the changes related to #10390 from this PR as that's already solved(and being solved) elsewhere already.
Also, you should open separate PRs for separate fixes unless they are really really related. It makes it easy to review and merge the PR
While updating the PR, I noticed that it is possible to book a event with length of 0. This is possible when saving the form from a tab other than the Event Setup.
We can solve it in two ways.
- Either not letting the form submit via RHF.
- On Submit, checking the value and throwing an Error like we do when there are no multiple durations selected.
I prefer the 2nd approach because If we use the 1st approach The user will not get any indication of an error on tabs other than Event Setup. And it also looks more consistent.
If you would like the 2nd approach too. What Error message do you want to be shown?
This PR is being marked as stale due to inactivity.
@MehulZR can you fix the conflicts in this PR?
@MehulZR just a heads up there's more conflicts