xero-php icon indicating copy to clipboard operation
xero-php copied to clipboard

Published 20 hours ago • verified publisher icon calcinai

Saving Item errors

Open theshelf opened this issue 7 years ago • 3 comments

When saving an item I was getting 2 errors: The first seems to be fixed in a pull request - InventoryAssetAccountCode should not be required.

The other is because addPurchaseDetail and addSalesDetail should be setPurchaseDetails and setSalesDetails. This would make the PurchaseDetails and SalesDetails an object rather than a collection.

theshelf avatar Oct 11 '17 00:10 theshelf

I can't be the only one encountering this problem?

theshelf avatar May 24 '18 04:05 theshelf

Hmm, I haven't specifically tested this. Do you have the time to propose a PR?

calcinai avatar May 24 '18 04:05 calcinai

Have just added PR #382

I have been using this code for about 6 months, only got reminded of that when I tried to do a composer update (for PHP 7.2 support) and was reminded that I had modified files.

theshelf avatar May 24 '18 04:05 theshelf