xero-php icon indicating copy to clipboard operation
xero-php copied to clipboard

ReportTaxType is hard coded to be required, but it is not required for US orgs

Open allauthors opened this issue 7 years ago • 1 comments

Steps to Reproduce.

  1. Set your demo account type to US.
  2. Attempt to create a TaxRate with out a ReportTaxType property... Result: Validation Fails before the request is ever sent to Xero. Expected Result: If the Org Version is "US" it should pass validation and send the request to Xero. Alternate Acceptable Result: Always let it pass validation and send the request to Xero.

If the Alternate is acceptable I'll be happy to send a pull request.

allauthors avatar Aug 04 '17 15:08 allauthors

Yeah for Global Too

ReportTaxType | See ReportTaxTypes. Required when creating tax rates for AU, NZ and UK orgs.

gkavaliu avatar Aug 31 '17 16:08 gkavaliu