aws-lambda-events

aws-lambda-events copied to clipboard

Add Default derive for structs that can support it

2

Many structs can be used part of the regular function code. It's very cumbersome to create them by hand if you only need to add a few fields, and want...

calavera

Cannot deserialize CodePipelineEventDetailType objects

3

Rust assumes that the version field in the `CodePipelineEventDetailType` should be a number, when in reality (the JSON CloudWatch sends) contains a string.

mhvelplund

SNS Message Attributes should use the new AWS SDK types and support binary values

1

https://github.com/LegNeato/aws-lambda-events/blob/632a850ed90503dbe07fceff1f354fc1df289c4c/aws_lambda_events/src/sns/mod.rs#L89 New SDK type: https://docs.rs/aws-sdk-sns/latest/aws_sdk_sns/model/struct.MessageAttributeValue.html This way, they could support binary values. (I discovered this because I'm making a lambda, that copies SNS messages cross account. Currently I have to...

matiu3

Move fixtures outside the generated directory

2

We use example files inside the generated module, and also outside of that module. It might make sense to move the fixtures directory outside the generated module.

calavera

AlbTargetGroupResponse automatically base64 encodes data

6

I'm using this to return some image data from a lambda: ```rust let resp = AlbTargetGroupResponse { status_code: 200, body: Some(Body::Binary(buf)), headers: HeaderMap::new(), is_base64_encoded: true, multi_value_headers: HeaderMap::new(), status_description: Some(String::from("200 OK")),...

WhyNotHugo

Use Rust as the source of truth / break with the Go SDK

2

_Eventually_ we'll probably want to have Rust as the source of truth rather than generating from Go. * Rust's type system is more expressive and can be more correct and...

LegNeato

We could use https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#schedule to look for changes in the go sdk and automatically put up a PR.

LegNeato

What is the rationale for converting empty strings to None?

5

Why not converting only `null` to `None` and leaving empty strings empty? The problem is loosing the information about whether the value was actually null or an empty string, neither...

Veetaha

We should (optionally) be smarter for URL types and parse them into `url` crate structs rather than keep them as strings.

LegNeato

We should generate a variant that borrows rather than owns (so &str rather than String for example). This will reduce allocations.

LegNeato