calamares-manjaro icon indicating copy to clipboard operation
calamares-manjaro copied to clipboard

track system config stuff

Open udeved opened this issue 8 years ago • 6 comments

keep track on stuff to do after moving config to livecd for iso

udeved avatar Aug 18 '16 17:08 udeved

Would be very nice if upstream implemented writing displaymanagers to globalstorage.

Right before last line's return in displaymanager main.py:

libcalamares.globalstorage.insert("displayManagers", displaymanagers)

I made it so that postcfg makes use of displayManagers, so manjaro doesn't have to deploy its own displaymanager module @philmmanjaro @teo .

udeved avatar Aug 19 '16 07:08 udeved

Fork the calamares repo, create a new branch if needed and modify the modules as you may think fit. Then request a normal pull so we can review your work upstream.

philmmanjaro avatar Aug 19 '16 07:08 philmmanjaro

I have pushed both in calamares-manjaro. However, just this one line should go upstream and we drop our displaymanager. ;)

udeved avatar Aug 19 '16 07:08 udeved

You have to create a pull request in calamares repo and not add a custom module to calamares-manjaro repo. I can review your work and create that pull request myself if needed. This however later, maybe tomorrow.

philmmanjaro avatar Aug 19 '16 07:08 philmmanjaro

I can do PR for this one line upstream change, no problem. Once its merged, we drop the custom displaymanager module.

udeved avatar Aug 19 '16 07:08 udeved

https://github.com/calamares/calamares/pull/251

@philmmanjaro

I took out keyboard.conf writing in postcfg, I think its useless.

udeved avatar Aug 19 '16 07:08 udeved