language-ethereum icon indicating copy to clipboard operation
language-ethereum copied to clipboard

Apostrophe in comment reduces indentation level on auto-indent

Open wbt opened this issue 7 years ago • 0 comments

Both of the following were auto-indented by Atom (with four spaces per indent for visual clarity).
This code looks properly indented:

pragma solidity ^0.4.0;
library RecordsLib { //you wouldnt expect this apostrophe to affect indentation!
    struct Data {
        uint timestamp;
        uint score;
    }
    function updateRecord(Data storage self, uint newTimestamp, uint newScore) public {
        self.timestamp = newTimestamp;
        self.score = newScore;
    }
}

This code does not:

pragma solidity ^0.4.0;
library RecordsLib { //you wouldn't expect this apostrophe to affect indentation!
struct Data {
    uint timestamp;
    uint score;
}
function updateRecord(Data storage self, uint newTimestamp, uint newScore) public {
    self.timestamp = newTimestamp;
    self.score = newScore;
}
}

and the only difference between them is a commented-out apostrophe, on a line after an open brace!

I noticed the same issue in javascript and the issue may generalize beyond this package, but my last attempts at opening auto-indent issues on Atom got moved to language-specific packages (so I'm starting out there with these reports).

Versions

Atom: 1.23.2 Electron: 1.6.15 Chrome: 56.0.2924.87 Node: 7.4.0 language-ethereum: 0.3.9 language-javascript: 0.127.6 OS : Windows 10

wbt avatar Feb 20 '18 21:02 wbt