language-ethereum icon indicating copy to clipboard operation
language-ethereum copied to clipboard

Remove file-icons integration

Open michaelbaudino opened this issue 8 years ago • 4 comments

The current file-icons integration has 3 bugs:

  1. the icon is not displayed for Solidity files
  2. the icon is not colorized for Solidity files
  3. the font is broken for the Ruby files

Before this PR: before

This PR fixes all 3 issues.

After this PR: after

michaelbaudino avatar Jun 23 '17 12:06 michaelbaudino

Maintainer of file-icons here. =) It might please you to know that the file-icons package now supports Solidity files with a dedicated icon, as of v2.1.8 (which was actually released 3 days after this PR was submitted, haha).

Solidity

If there are any file-extensions that are missing, please don't hesitate to open an issue or submit a pull-request. =)

Alhadis avatar Aug 01 '17 10:08 Alhadis

@Alhadis Thanks for notification 🎩

@caktux I updated this PR to simply not define any style... the one from file-icons will be used and it looks like this:

screenshot-solidity-icons

michaelbaudino avatar Aug 01 '17 17:08 michaelbaudino

You're most perfectly welcome, mate. :)

Alhadis avatar Aug 01 '17 17:08 Alhadis

@caktux Is this repository still maintained?

Alhadis avatar Mar 01 '18 12:03 Alhadis