phinx icon indicating copy to clipboard operation
phinx copied to clipboard

SQL Server adapter uses nvarchar(max) instead of ntext and always updates default constraint

Open atbigelow opened this issue 4 years ago • 5 comments

The first commit of this PR handles #1972, which is to remove the use of NTEXT and replace it with NVARCHAR(MAX). The existing NTEXT and TEXT parsing to the Phinx TEXT type still exists for compatibility reasons.

The second commit forces default constraints to always be dropped and readded, as SQL Server requires this to be removed if the column is ever changed.

atbigelow avatar Apr 29 '21 18:04 atbigelow

Any update? Or shall we close this?

dereuromark avatar Sep 03 '21 11:09 dereuromark

Went ahead and updated these. Sorry on the delay.

atbigelow avatar Sep 03 '21 20:09 atbigelow

Do we want to continue and merge? @MasterOdin

dereuromark avatar Mar 29 '22 11:03 dereuromark

Ping @MasterOdin

dereuromark avatar Sep 07 '23 14:09 dereuromark

I wonder if we might need a test case here to back things up.

dereuromark avatar Dec 20 '23 07:12 dereuromark