migrations icon indicating copy to clipboard operation
migrations copied to clipboard

Fixes #500 . If precision is 0 command adds it anyway.

Open ajibarra opened this issue 2 years ago • 4 comments

Changing empty to is_null avoids ignoring decimal(X,0) and snapshot is generated correctly. Fixes #500

ajibarra avatar Sep 16 '22 06:09 ajibarra

@ADmad Same situation than #561

psalm reports:

Error: vendor/laminas/laminas-diactoros/src/functions/marshal_headers_from_sapi.php:29:18: ParseError: Syntax error, unexpected T_STRING, expecting T_PAAMAYIM_NEKUDOTAYIM on line 29 (see https://psalm.dev/173)
Error: vendor/laminas/laminas-diactoros/src/functions/marshal_headers_from_sapi.php:29:28: ParseError: Syntax error, unexpected T_VARIABLE, expecting ')' on line 29 (see https://psalm.dev/173)

If you have any clue about how to fix it, it is more than welcome :)

See https://github.com/cakephp/migrations/pull/561#issuecomment-1241684023

ajibarra avatar Sep 16 '22 06:09 ajibarra

If you have any clue about how to fix it, it is more than welcome :)

When I've run into this in the past it was the php version being too low in composer.json. Try bumping it to >=7.4.0.

markstory avatar Sep 17 '22 02:09 markstory

If you have any clue about how to fix it, it is more than welcome :)

When I've run into this in the past it was the php version being too low in composer.json. Try bumping it to >=7.4.0.

Hey @markstory, yes it may fix the issue as well, I've fixed changing coding standards php to 7.2 per Admad's recommendation and it worked. However if you prefer increasing php requirements to 7.4 I can make that change.

Thanks you!

ajibarra avatar Sep 17 '22 03:09 ajibarra

However if you prefer increasing php requirements to 7.4 I can make that change.

I think that's a safe change to make as 4.4 also requires php7.4.

markstory avatar Sep 19 '22 02:09 markstory

Looks good!

dereuromark avatar Sep 23 '22 10:09 dereuromark