docs icon indicating copy to clipboard operation
docs copied to clipboard

French documentation still include the RequestHandler in cakephp 5

Open ronaldcarucci opened this issue 1 year ago • 5 comments

Hi everybody,

I'm creating this issue because I was in the case and my problem is solved thanks to @markstory via email.

I'm from belgium and my google search result give me the French documentation of CakePHP 5.

On this page we can see the use of RequestHandlerComponent. But that component is removed since the release of CakePHP 5.

For my job I wrote in CakePHP 4 a controller containing the generic logical of REST and another controllers can extend it to have automatically the CRUD thanks to that logical.

For a personal project I wanted to do this in CakePHP 5 but it's didn't work because the documentation is erroned.

After contacting @markstory via email, he advised me to refer to the English documentation with is always up to date, and I will be able to finish my project thanks to that.

It's possible to update the French documentation to avoid another French developers (experimented or not) meet the same problem than me ?

Thank you

ronaldcarucci avatar Oct 16 '24 12:10 ronaldcarucci

It's possible to update the French documentation to avoid another French developers (experimented or not) meet the same problem than me ?

We rely on community contributions to maintain the non English docs. So it would be best if the French speakers submit fixes for issues they find instead of expecting someone else to do it.

ADmad avatar Oct 16 '24 13:10 ADmad

I'd tkink there are community contributors who usually update the documentation for the non English docs.

For that we can "just" edit the rst files into a separate branch for submit the changes to apply ?

ronaldcarucci avatar Oct 16 '24 13:10 ronaldcarucci

As a side note for those upgrading to Cake5: If you want to quickly get things up and running first before further refactoring, the RequestHandler component lives on in the Shim plugin: https://github.com/dereuromark/cakephp-shim/blob/master/docs/Component/RequestHandler.md With this usually it is a 1:1 replacement and things work again for a while if needed.

dereuromark avatar Oct 16 '24 13:10 dereuromark

For that we can "just" edit the rst files into a separate branch for submit the changes to apply ?

Yes

ADmad avatar Oct 16 '24 13:10 ADmad

Okey.

If I have some time to spend to this I can try myself and submit it. Unless someone has already done it before me

ronaldcarucci avatar Oct 16 '24 13:10 ronaldcarucci

I cannot create a new branch for submit merge request : Image

ronaldcarucci avatar Nov 06 '24 19:11 ronaldcarucci

You need to fork the repo and create a pull requeust based on your fork. You can't directly commit to this repo.

LordSimal avatar Nov 06 '24 19:11 LordSimal

You need to fork the repo and create a pull requeust based on your fork. You can't directly commit to this repo.

Okay, I didn't know before. This is my first contribution for a GitHub project. Thanks @LordSimal !

ronaldcarucci avatar Nov 06 '24 20:11 ronaldcarucci

I've create a fork. I have to update the 5.x branch or I must create a separate one ?

ronaldcarucci avatar Nov 06 '24 20:11 ronaldcarucci

I've create a fork. I have to update the 5.x branch or I must create a separate one ?

It's Okay, I found !

ronaldcarucci avatar Nov 06 '24 20:11 ronaldcarucci

The fork is merged and the documentation is up to date right now. Can I close this issue myself or someone else have to do this later ?

ronaldcarucci avatar Nov 08 '24 08:11 ronaldcarucci

And before I forget, I want to thank you guys for helping me contribute to this project

ronaldcarucci avatar Nov 08 '24 08:11 ronaldcarucci

Can I close this issue myself or someone else have to do this later ?

We can take care of closing issues. If you'd like to have the issue automatically close when the pull request is merged you can put Fixes #7929 in the pull request description/commit messages, and upon merge github will close the issue automatically.

markstory avatar Nov 08 '24 20:11 markstory