codeception icon indicating copy to clipboard operation
codeception copied to clipboard

Fix phpcs violation

Open josegonzalez opened this issue 8 years ago • 8 comments

josegonzalez avatar Feb 29 '16 06:02 josegonzalez

@jadb looks like the changes in 2.1 completely break the plugin because of path changes (lolol bc). Any ideas as to what we can fix to get this working again?

josegonzalez avatar Feb 29 '16 09:02 josegonzalez

We need to upgrade codeception to add 3.2 support because 2.0.x requires symfony/yaml 2.x and cakephp 3.2 requires symfony/yaml 3.x.

josegonzalez avatar Feb 29 '16 09:02 josegonzalez

Why does cake 3 require yaml?

lorenzo avatar Mar 05 '16 20:03 lorenzo

Not sure about cake but should be updating this plugin soon as I use it on new application and make changes. Which reminds me to ask, @josegonzalez would you be available for an interview?

jadb avatar Mar 06 '16 01:03 jadb

@lorenzo no fucking idea.

I'm available.

josegonzalez avatar Mar 07 '16 16:03 josegonzalez

@lorenzo @josegonzalez If this is installing cakephp/app, symfony/yaml is required by the migrations plugin (which requires phinx, which requires it).

HavokInspiration avatar Mar 07 '16 16:03 HavokInspiration

Using composer show --tree should show the dependencies in a tree view.

dereuromark avatar Mar 07 '16 16:03 dereuromark

@HavokInspiration gotcha. I wonder if I can create the app in --dev mode to avoid the yaml requirement.

Note that it wouldn't matter, since we still need both installed in dev...

josegonzalez avatar Mar 07 '16 16:03 josegonzalez