authorization icon indicating copy to clipboard operation
authorization copied to clipboard

move unauthorizedHandler to AuthorizationService

Open saeideng opened this issue 3 years ago • 4 comments

saeideng avatar Feb 14 '22 14:02 saeideng

do we need move all configs from AuthorizationMiddleware to AuthorizationService or only the unauthorizedHandler ?

my opinion : moving all

saeideng avatar Feb 17 '22 16:02 saeideng

my opinion : moving all

Would you also be moving all the logic related to these options to the service as well?

markstory avatar Feb 22 '22 03:02 markstory

my opinion : moving all

Would you also be moving all the logic related to these options to the service as well?

not sure , but I can try it

saeideng avatar Feb 26 '22 20:02 saeideng

I didn't see this PR earlier. #211 adds the unauthorizedHandler to both the middlewares using a trait instead.

ADmad avatar Sep 29 '22 05:09 ADmad