cake_wallet icon indicating copy to clipboard operation
cake_wallet copied to clipboard

Published 20 hours ago • verified publisher icon cake-tech

fix for building on ios

Open fossephate opened this issue 7 months ago • 4 comments

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • [ ] Initial Manual Tests Passed
  • [ ] Double check modified code and verify it with the feature/task requirements
  • [ ] Format code
  • [ ] Look for code duplication
  • [ ] Clear naming for variables and methods

fossephate avatar Nov 29 '23 16:11 fossephate

we tried this and it didn't work, right? we said that we are going to specify the commit from which to clone the repo

OmarHatem28 avatar Dec 07 '23 14:12 OmarHatem28

@OmarHatem28 IIRC, I couldn't get it to work even when I did specify the commit hash :/ though that probably is the solution

fossephate avatar Dec 13 '23 20:12 fossephate

we said that we are going to specify the commit from which to clone the repo

This commit worked for me: 443617d7507498f7477703f0b51cb596d4539262.

itswisdomagain avatar Dec 20 '23 09:12 itswisdomagain

@itswisdomagain thanks for providing some insights on this.

@fossephate we would need to test this again to verify that it's working with your changes, but we will still need to specify a commit to avoid any unexpected behavior if the stable branch is updated

OmarHatem28 avatar Dec 22 '23 02:12 OmarHatem28