cake_wallet icon indicating copy to clipboard operation
cake_wallet copied to clipboard

F-Droid Support

Open tannerdsilva opened this issue 3 years ago • 40 comments

This issue a carryover from #105, in which two topics were brought up and one was resolved. The outstanding topic is related to F-Droid support, and is the primary concern of this issue.

In issue #105, @mezzazon mentioned that F-Droid support is in the works, but adding such support created various constraints that we need to avoid to ensure a complete experience for all users.

As F-Droid support evolves, this issue will be updated accordingly.

tannerdsilva avatar Apr 11 '21 19:04 tannerdsilva

There is open RFP (Request For Packaging) at F-droid in: https://gitlab.com/fdroid/rfp/-/issues/1227

emanuelb avatar May 06 '21 12:05 emanuelb

F-Droid maintainer here. The main thing currently missing are Fastlane structures (minimal set would be short_description.txt and full_description.txt in fastlane/metadata/android/en-US, screenshots are highly recommended). Once that's established please give us a ping and we can trigger our issuebot for an up-to-date scan to see where we stand; with some luck, integration can be started right away from there.

IzzySoft avatar May 06 '21 18:05 IzzySoft

We will back to F-Droid support after next major release. Actually there is issue with secrets which we are generating for our app on building stage, they are using as salt for some encryption processes. So we need to decide how to handle this situation for F-Droid builds.

mkyq avatar May 10 '21 12:05 mkyq

That could possibly be included with the F-Droid build process (as part of the so called "build recipe") as well, as long as it only relies on FOSS tools (like packages that can be installed from the standard Debian repos and are then called to produce the "salt").

IzzySoft avatar May 11 '21 15:05 IzzySoft

We will back to F-Droid support after next major release. Actually there is issue with secrets which we are generating for our app on building stage, they are using as salt for some encryption processes. So we need to decide how to handle this situation for F-Droid builds.

And update on this? Should be a top priority.

Also, latest update included push notifications, mind if I ask what method you used? Another "Foss" app claims there are no solutions aside from google fcm. (Of course, this isn't true)

nahuhh avatar Jun 10 '21 12:06 nahuhh

We will back to F-Droid support after next major release. Actually there is issue with secrets which we are generating for our app on building stage, they are using as salt for some encryption processes. So we need to decide how to handle this situation for F-Droid builds.

And update on this? Should be a top priority.

Sorry we had some other integrations for that time. We are planning to back to this around 21 June.

mkyq avatar Jun 10 '21 12:06 mkyq

We will back to F-Droid support after next major release. Actually there is issue with secrets which we are generating for our app on building stage, they are using as salt for some encryption processes. So we need to decide how to handle this situation for F-Droid builds.

And update on this? Should be a top priority.

Sorry we had some other integrations for that time. We are planning to back to this around 21 June.

Appreciate it. Cheers

nahuhh avatar Jun 10 '21 13:06 nahuhh

Still working on it.

CakeWallet avatar Jun 22 '21 11:06 CakeWallet

The Play Store API might have temporarily broken Aurora, so Cake doesn't appear to be there now. I'd love to be able to install and update from F-Droid, so count this as moral support for the F-Droid effort.

Thanks for working on this.

apotheon avatar Aug 05 '21 17:08 apotheon

The Play Store API might have temporarily broken Aurora, so Cake doesn't appear to be there now. I'd love to be able to install and update from F-Droid, so count this as moral support for the F-Droid effort.

Thanks for working on this.

We just back to integration into F-Droid again. We will work on option to build the app without push notifications which require google api.

mkyq avatar Aug 06 '21 10:08 mkyq

The Play Store API might have temporarily broken Aurora, so Cake doesn't appear to be there now. I'd love to be able to install and update from F-Droid, so count this as moral support for the F-Droid effort.

Thanks for working on this.

We just back to integration into F-Droid again. We will work on option to build the app without push notifications which require google api.

Please do. No need / want for Google push services on the Premier monero wallet.

Have also never received a push notification, so not sure what it's used for (exchanges maybe?)

nahuhh avatar Aug 06 '21 11:08 nahuhh

I imagine some people want push notifications for something like notification that a transaction went through, or got X confirmations, or something like that, but I'm not sure whether that's the use case for push notifications with Cake. I haven't really used it yet, in part because of the lack of F-Droid support. I'm looking forward to F-Droid availability now.

apotheon avatar Aug 06 '21 18:08 apotheon

I imagine some people want push notifications for something like notification that a transaction went through, or got X confirmations, or something like that, but I'm not sure whether that's the use case for push notifications with Cake. I haven't really used it yet, in part because of the lack of F-Droid support. I'm looking forward to F-Droid availability now.

Agreed. Currently cake disconnects when in the background (at least, on android), and I've never received a push notification with the current implementation.

I wouldn't mind a FOSS alternative, even a polling solution or a persistent notification.

Idk what the play store version ships with, it can have all the tracking available. Lol. but a clean f droid build is what I desire.

nahuhh avatar Aug 06 '21 18:08 nahuhh

@CakeWallet uses push notifications for remind about updates in new versions of the app and notify users that released new version.

mkyq avatar Aug 06 '21 18:08 mkyq

@mezzazon then you won't need that in the F-Droid build anyhow: as F-Droid has its own signing process, APKs signed by you wouldn't be compatible (signature mismatch), and updates available at F-Droid itself are reported by the F-Droid client.

Should you ever need push notifications for something else, take a look at my notes here. UnifiedPush is already supported via Gotify-UP which is available at F-Droid.

IzzySoft avatar Aug 10 '21 20:08 IzzySoft

Since Monero and F-Droid both value the openness and privacy, F-droid support will really be beneficial.

BraINstinct0 avatar Dec 03 '21 01:12 BraINstinct0

@IzzySoft Looking at another issue #198 , I've found out that currently at least three third-party service(s) are being indirectly used.

  • https://xmrchain.net : for XMR
  • https://www.blockchain.com : for BTC
  • https://blockchair.com : for LTC Among these three, only xmrchain.net's source is publicly available; the other two is proprietary, closed-source, hence promoting usage of non-free network services.

(Don't get me wrong, there is just a requirement to notify, not remove it altogether. Giving alternatives or stripping away does work but you should weigh between functionality and openness.)

relevant source(s): Sites used for the transaction detail view

BraINstinct0 avatar Dec 03 '21 01:12 BraINstinct0

@BraINstinct0 good points. For F-Droid, that would be covered by the NonFreeNet anti-feature – while FCM (here for push notifications) would block inclusion. May I again point to UnifiedPush, which just got a few more distributors ("back-ends") added? See my list here.

IzzySoft avatar Dec 03 '21 07:12 IzzySoft

Sorry that we hold pause on this. We are working on couple of new releases and then we will back to fdroid integration.

mkyq avatar Dec 03 '21 11:12 mkyq

No worries, I'd rather wait for(or contribute for) stable F-Droid supported release than get early hit-and-mostly-miss releases. I'm leaving notes so that F-Droid support can be a little, if any, smoother and more guaranteed - because I do like CakeWallet 😉

BraINstinct0 avatar Dec 03 '21 12:12 BraINstinct0

Well, you certainly cannot clone yourself to get more jobs done within the same time, so you have to set priorities :wink: We gladly help you when you're ready for it – the sooner the happier, but with patience of course :smile:

IzzySoft avatar Dec 03 '21 12:12 IzzySoft

Since Monero and F-Droid both value the openness and privacy, F-droid support will really be beneficial.

If FCM is the only disqualifying non-feature, as a part of the community, I would greatly appreciate that a FLOSS cake wallet is released with greater priority than ztrash.

People are skeptical, and I believe there to be some justinfication to that.

.. Good morning.

nahuhh avatar Dec 03 '21 13:12 nahuhh

Well, you certainly cannot clone yourself to get more jobs done within the same time, so you have to set priorities 😉 We gladly help you when you're ready for it – the sooner the happier, but with patience of course 😄

Or, if it doesn't seem to be timely, we cannot clone mezzazon but we can clone cake_wallet - that's one of what oss is for, doing the right thing when things seem to be going the other way. But, I can wait. :)

BraINstinct0 avatar Dec 03 '21 14:12 BraINstinct0

Would love to see this on F-Droid.

trymeouteh avatar Mar 23 '22 17:03 trymeouteh

Just fell on this once more during the latest triage run at F-Droid. Any progress so far? We'd like to keep the number of "dormant issues" at a minimum, and there was no update for almost a year now. Any ETA? Shall I set another reminder for a heads-up? No pressure, but it would be good to know where we stand :wink:

IzzySoft avatar Apr 02 '22 19:04 IzzySoft

@BraINstinct0 good points. For F-Droid, that would be covered by the NonFreeNet anti-feature – while FCM (here for push notifications) would block inclusion. May I again point to UnifiedPush, which just got a few more distributors ("back-ends") added? See my list here.

To rebump

Edit:

Status IM has recently added firebase to their messenger app. The Google play release includes firebase notifications option, but the f droid release does not. Added firebase im assuming to imorove background reliability for regular folks that dont care about the Foss aspect.

nahuhh avatar Apr 14 '22 11:04 nahuhh

@mkyq any response to my above question? As the RFP is still dormant, it will now enter the closure phase: it's now 1 year that we got the last response there.

IzzySoft avatar Jun 01 '22 07:06 IzzySoft

@mkyq any response to my above question? As the RFP is still dormant, it will now enter the closure phase: it's now 1 year that we got the last response there.

@SamsungGalaxyPlayer

nahuhh avatar Jun 01 '22 08:06 nahuhh

We can close this on the official fdroid repo side for now. We will likely use our own repo.

SamsungGalaxyPlayer avatar Jun 01 '22 14:06 SamsungGalaxyPlayer

Thanks @SamsungGalaxyPlayer – closing then. Should you one day re-decide, just knock on our door. All the best for your project – and the new repo!

IzzySoft avatar Jun 01 '22 22:06 IzzySoft