Cake.Recipe icon indicating copy to clipboard operation
Cake.Recipe copied to clipboard

Remove workaround for OpenCover

Open Jericho opened this issue 8 years ago • 7 comments

In PR #162 we implemented a workaround for a know issue in OpenCover (specifically: run open cover with the -oldstyle parameter). This workaround is for OpenCover 4.6.519 but it will no longer be necessary when the next version of OpenCover is released.

Jericho avatar Oct 17 '17 12:10 Jericho

@Jericho thanks for adding this!

gep13 avatar Oct 17 '17 14:10 gep13

I missed the annoucement but evidently there was a new version of OpenCover published in February (after almost 3 years!!!). I'll investigate if we can remove the workaround.

Jericho avatar Apr 23 '19 19:04 Jericho

I could be wrong, but I believe I tested out right after that release came out, and found the need to use -oldstyle was still there.

AdmiringWorm avatar Apr 24 '19 05:04 AdmiringWorm

Sadly, it looks like @AdmiringWorm is right. I have been trying to run opencover on my project without the -oldstyle switch and I am getting errors like:

System.MissingMethodException : Method not found: 'Void System.CannotUnloadAppDomainException.SafeVisited(Int32)'.

On the bright side, it looks like OpenCover now support Portable PDBs. It used to require Full PDB but I switched one of my projects and, so far, coverage is being calculated correctly.

Jericho avatar Apr 27 '19 14:04 Jericho

On the bright side, it looks like OpenCover now support Portable PDBs.

Well, at least there are 1 silver lining then. 1 Benefit is better than none.

AdmiringWorm avatar Apr 27 '19 14:04 AdmiringWorm

@Jericho is this still an issue?

gep13 avatar Sep 09 '19 19:09 gep13

@gep13 there hasn't been a new release of OpenCover since I last tested therefore this is still an issue.

Jericho avatar Sep 09 '19 21:09 Jericho