website icon indicating copy to clipboard operation
website copied to clipboard

Change to H2 for TOC

Open pascalberger opened this issue 4 years ago • 11 comments

We currently use H1 in our document pages to build the TOC on the right hand column. To follow semantic best practices we should only have one H1 on the page (the title) and use headings starting with H2 for structuring page content.

We would need to configure Wyam to pickup H2 for building the TOC:

Pipelines["RenderPages"].InsertAfter("WriteMetadata", new Headings(3); // Heading level

pascalberger avatar Oct 08 '20 06:10 pascalberger

I can take care of this.

marekgebka avatar Oct 08 '20 09:10 marekgebka

@marekgebka Great. Let me know if you have questions or need further information.

pascalberger avatar Oct 08 '20 10:10 pascalberger

@marekgebka Are you still interested in giving this a try? Do you need any further information?

pascalberger avatar Oct 17 '20 20:10 pascalberger

Hey, yes I am. I've been pretty busy lately. Thank you for your patience.

marekgebka avatar Oct 18 '20 08:10 marekgebka

@pascalberger I've started do some digging and tried to get the site up and running but after running a build I am greeted with the following output.

`It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '2.1.0' was not found.
  - The following frameworks were found:
      3.1.9 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

You can resolve the problem by installing the specified framework and/or SDK.

The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=2.1.0&arch=x64&rid=win10-x64 `

I already checked the link and it seems like it is no longer offered. Is a downgrade really the onyl way to go here?

marekgebka avatar Oct 18 '20 11:10 marekgebka

@marekgebka Can you please list what exactly you did, how you run the build and what OS/Version?

pascalberger avatar Oct 18 '20 20:10 pascalberger

@pascalberger I am actually seeing a similar problem on my Mac when testing today...

image

To get this to happen, I ran:

git clean -xfd

To get to a clean slate, and then I ran:

./build.sh --target=preview

gep13 avatar Oct 21 '20 12:10 gep13

In build.ps1 we set

$env:DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
$env:DOTNET_CLI_TELEMETRY_OPTOUT=1
$env:DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX=2

but in build.sh

export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
export DOTNET_CLI_TELEMETRY_OPTOUT=1
export DOTNET_SYSTEM_NET_HTTP_USESOCKETSHTTPHANDLER=0

the DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX is missing in bash file.

devlead avatar Oct 21 '20 12:10 devlead

@devlead ooo, testing this just now...

gep13 avatar Oct 21 '20 12:10 gep13

@devlead new PR raised here:

https://github.com/cake-build/website/pull/1149

gep13 avatar Oct 21 '20 12:10 gep13

@marekgebka Can you please list what exactly you did, how you run the build and what OS/Version?

Sorry for the late reply. I am currently using Win10. As far as I remember the steps were the following:

  • Install cake dotnet tool install Cake.Tool (I think I had no version specified)
  • Install wyam dotnet tool install -g Wyam.Tool
  • tried to run the build with wyam build --target=Build

Sorry I let you all wait for so long. Please feel free to assign this issue to someone else. Work is pretty draining atm and I am not doing much besides that.

marekgebka avatar Nov 15 '20 14:11 marekgebka