resources icon indicating copy to clipboard operation
resources copied to clipboard

Version number ignored in Addins\packages.config

Open xclayl opened this issue 8 years ago • 3 comments

Start with this packages.config file:

<packages>
    <package id="Microsoft.SqlServer.DacFx.x86" version="130.3485.1" />
</packages>

run build.ps1 and it'll download the package.

Update packages.config with the new version:

<packages>
    <package id="Microsoft.SqlServer.DacFx.x86" version="140.3745.1" />
</packages>

and run build.ps1.

The Addins folder incorrectly contains version 130.3485.1.

This scenario plays out when you commit the packages.config folder to source control, but not the packages themselves. When one developer updates packages.config, all the other developers continue to use the old version of the package.

xclayl avatar Aug 30 '17 04:08 xclayl

The tools folder contains "packages.config.md5sum". Perhaps something similar can be done here to detect a change to Addins\packages.config.

xclayl avatar Aug 30 '17 04:08 xclayl

@xclayl the advice going forward is likely to be to NOT use the packages.config files. Rather, define your tools/addins via the pre-processor directive. This gives much greater flexibility (i.e. you can define different sources for different packages), and also will cover things like dependencies, etc.

Follow here:

https://github.com/cake-build/cake/issues/1743

for more information.

gep13 avatar Aug 30 '17 06:08 gep13

Thanks -- looking forward to it. :)

xclayl avatar Aug 30 '17 21:08 xclayl