cake icon indicating copy to clipboard operation
cake copied to clipboard

Extensibility issue - CakeTaskBuilder is sealed and CakeTaskBuilder(CakeTask task) is internal.

Open vijaygill opened this issue 4 years ago • 4 comments

While attempting a little idea in my mind, I tried implementing my own cake engine (by implementing ICakeEngibe) but faced following issue:

CakeTaskBuilder(CakeTask task) is marked as internal and the class itself is sealed. So I cannot implement my own CakeTaskBuilder ICakeEngine.RegisterTask(string name) in the new cake-engine class (on the same lines as the original one. Also CakeEngine itself is marked as sealed. So I cannot subclass it and override some functionality.

As suggested on the chat, I am opening this issue so that the cake can be refactored to make it more extensible (after discussing it here).

Thanks.

vijaygill avatar Aug 05 '19 16:08 vijaygill

@vijaygill thanks!

/cc @patriksvensson this is what we discussed.

bjorkstromm avatar Aug 05 '19 17:08 bjorkstromm

@mholo65 I will take a look and see what needs to be done

patriksvensson avatar Aug 05 '19 22:08 patriksvensson

@patriksvensson Did you get a chance to look at this please?

vijaygill avatar Jan 24 '20 11:01 vijaygill

@pascalberger I've created a small PR to fix this long standing issue.

twenzel avatar Sep 01 '22 19:09 twenzel

:tada: This issue has been resolved in version v2.3.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket:

cake-build-bot avatar Oct 14 '22 11:10 cake-build-bot