cake-vs icon indicating copy to clipboard operation
cake-vs copied to clipboard

[WIP] LSP integration

Open bjorkstromm opened this issue 6 years ago • 3 comments
trafficstars

@gep13 or @agc93 anyone of you want to continue with this? The newer OmniSharp builds now has much more stable LSP implementation.

bjorkstromm avatar Mar 19 '19 19:03 bjorkstromm

Yeah, I'll try and have a look. I was chatting to @madskristensen about this stuff this morning so I want to try and give it another crack with the more stable bits from O# and the more stable bits from the VS end as well.

agc93 avatar Mar 19 '19 19:03 agc93

Currently blocked running into https://github.com/OmniSharp/csharp-language-server-protocol/issues/132.

For my own reference, we still have a couple of big questions to sort out before we ship this:

  • Do we ship O# in-VSIX? Download on first use?
  • Do we try and locate/use the O# used from VS Code if its available?
  • How do we stop the server? Does StopAsync actually get called or is it usual VS trickery?

agc93 avatar Mar 25 '19 19:03 agc93

@agc93 I’ve submitted a fix to OmniShatp here https://github.com/OmniSharp/omnisharp-roslyn/pull/1503, once that’s merged, you can get the latest OmniSharp bits from the blob and try this out agan.

bjorkstromm avatar May 22 '19 20:05 bjorkstromm