caishunfeng

Results 65 comments of caishunfeng

Hi @shangshang11 please see the doc https://dolphinscheduler.apache.org/zh-cn/development/backend/spi/datasource.html BTW, please use English to describe next time, which can make more developers understand, thanks.

> s I am willing to submit a PR OK, I assign to you now @lenian , looking forward to your pr.

> > This is a case where unit test is helpful and should be mandatory, to verify that the nested types can be parsed without error. Can you add some?...

>Is it possible to use a simpler way instead of Netty for communication between worker and master in K8S environment? Such as a message queue? +1, I think if k8s...

> Hi, @iamcaoxudong , maybe we could just delete this method, since it is not used anymore after #15367 as you mentioned +1, @iamcaoxudong can you update this pr?

Please add the purpose of the pull request.

https://github.com/apache/dolphinscheduler/blob/68a190674fe7f6d0e957fca1efa085b067224cb7/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/CheckUtilsTest.java#L109 It seems `file://` is illegal path but the url prefix is `file:/`.

I think it's good idea to add a `DS-Job` plugin to trigger third-part system method/task. But it should be isolated from third-party systems at the database, it seems no need...

> We can directly remove `listResources`, this method is never used. Good advice, had remove these unuse mapper method.