js-dos icon indicating copy to clipboard operation
js-dos copied to clipboard

[js-dos v7 beta 30] sound hiccups in Chrome

Open maximilien-noal opened this issue 4 years ago • 10 comments

While js-dos v7 fixes the controls problem in Chrome with Prince of Persia, and the high-pitched sound in Another World (both problems are from js-dos v6.22), I can't fix this no matter what setting I try.

The js-dos bundle this can be tested are below (Another World, Prince of Persia)

In Firefox, the sound is fine.

AnotherWorld.jsdos.zip PoP.jsdos.zip

Thank you again for this awesome emulator !

maximilien-noal avatar Apr 24 '21 16:04 maximilien-noal

Can you record an example how it sounds like? Anyway I will replace audio library soon.

caiiiycuk avatar Apr 27 '21 14:04 caiiiycuk

Will do (soon) !

maximilien-noal avatar Apr 27 '21 20:04 maximilien-noal

Here it is for Another World with Chrome :

https://www.youtube.com/watch?v=_Qn2WfN1YAE

I can upload the result with Firefox or anything else that might help. Just ask ! :)

My system: Intel Core i7 6700K @ 4 GHz Windows 10 x64 nVidia GeForce GTX 1070

maximilien-noal avatar Apr 28 '21 19:04 maximilien-noal

Do you need more information or videos ?

maximilien-noal avatar Jun 04 '21 09:06 maximilien-noal

No thanks, I think I will try to fix it on next week

caiiiycuk avatar Jun 05 '21 10:06 caiiiycuk

This is tricky. possible solution here is to create AudioWorklet and send data to it using MessagePort.

caiiiycuk avatar Jun 30 '21 09:06 caiiiycuk

Curious to know if this is fixed in the latest v7 releases ?

maximilien-noal avatar Dec 22 '21 15:12 maximilien-noal

Not yet

caiiiycuk avatar Dec 23 '21 03:12 caiiiycuk

@maximilien-noal do you hear any sound differences between this versions: https://dos.zone/out-of-this-world-1992/ https://dos.zone/out-of-this-world-1992/?direct=1 https://shd.dos.zone/out-of-this-world-1992/

caiiiycuk avatar Mar 15 '22 04:03 caiiiycuk

Test browser: Chrome (Version 99.0.4844.74) Same hardware config as above.

First one : moderate and constantly present sound hiccups. Second one : exact same thing Third one : exact same thing,

maximilien-noal avatar Mar 17 '22 19:03 maximilien-noal