caido icon indicating copy to clipboard operation
caido copied to clipboard

Changes to a replay are lost if the request is in-flight

Open wbowling opened this issue 3 years ago • 2 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help us know what to work on
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Bug description

After sending a replay, any changes made to the request are lost when the response comes in.

How to reproduce

  1. Send a request to the replays tab
  2. Send the replay
  3. Before the response comes back, make some changes
  4. The changes are replaced when the response comes back

Environment & setup

OS: macOS OS version: 12.2 Caido version: 0.15.0-13a2d7e6

wbowling avatar May 30 '22 22:05 wbowling

This was only really an issue when working with a very slow/flakey server, after waiting a bit I often found that I wanted to change the request but if I didn't hit cancel the changes were replaced if the response finally came back.

A potential solution is to have a new "pending" request page which gets activated anytime you edit a request. This would allow you to edit an in-flight request (it would go into the pending mode) and if the response comes in it just gets added to the list like normal

wbowling avatar May 30 '22 23:05 wbowling

Closed by mistake, this isn't fixed yet.

Corb3nik avatar May 16 '24 19:05 Corb3nik